Skip to content

Exclude protogen from code coverage reports #3151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Exclude protogen from code coverage reports #3151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gradle/root.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ tasks.register('codeCoverageReport', JacocoReport) {
def exclusions = [
"**/*Proto.class", "**/*Proto\$*.class",
"**/planprotos/*", "**/eventprotos/*",
"**/generated/*", "**/grpc/v1/**/*"
"**/generated/*", "**/grpc/v1/**/*",
"**/protogen/*"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are class / package names, not build source directory names. What classes have protogen in their package name?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! In that case, this won't work.
This is from com.apple.foundationdb.relational.continuation.
Basically the classes defined in https://github.com/FoundationDB/fdb-record-layer/blob/main/fdb-relational-core/src/main/proto/continuation.proto

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there isn't anything more distinctive than the class name itself. Though perhaps renaming it to have Proto in it would be worth considering.

]

def compiledFiles = coverageSubprojects.collect { sp ->
Expand Down
Loading