Skip to content

Rewrite the data-loader in go and allow the data-loader to be modified #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,6 @@ COPY kubectl-fdb/ kubectl-fdb/
# Build
RUN CGO_ENABLED=1 GOOS=linux GOARCH=amd64 GO111MODULE=on make manager plugin-go

# Create user and group here since we don't have the tools
# in distroless
RUN groupadd --gid 4059 fdb && \
useradd --gid 4059 --uid 4059 --create-home --shell /bin/bash fdb && \
mkdir -p /var/log/fdb && \
touch /var/log/fdb/.keep

FROM docker.io/rockylinux/rockylinux:9.5-minimal

ARG FDB_VERSION
Expand All @@ -63,11 +56,14 @@ RUN set -eux && \
rpm -i foundationdb-clients-${FDB_VERSION}-1.el7.x86_64.rpm --excludepath=/usr/bin --excludepath=/usr/lib/foundationdb/backup_agent && \
rm foundationdb-clients-${FDB_VERSION}-1.el7.x86_64.rpm foundationdb-clients-${FDB_VERSION}-1.el7.x86_64.rpm.sha256

COPY --from=builder /etc/passwd /etc/passwd
COPY --from=builder /etc/group /etc/group

RUN groupadd --gid 4059 fdb && \
useradd --gid 4059 --uid 4059 --shell /usr/sbin/nologin fdb && \
mkdir -p /var/log/fdb && \
touch /var/log/fdb/.keep

COPY --chown=fdb:fdb --from=builder /workspace/bin/manager .
COPY --chown=fdb:fdb --from=builder /workspace/bin/kubectl-fdb /usr/local/bin/kubectl-fdb
COPY --chown=fdb:fdb --from=builder /var/log/fdb/.keep /var/log/fdb/.keep

# Set to the numeric UID of fdb user to satisfy PodSecurityPolices which enforce runAsNonRoot
USER 4059
Expand Down
2 changes: 2 additions & 0 deletions e2e/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ STORAGE_ENGINE?=
DUMP_OPERATOR_STATE?=true
SEAWEEDFS_IMAGE?=chrislusf/seaweedfs:3.73
NODE_SELECTOR?=
DATA_LOADER_IMAGE?=
# Defines the cloud provider used for the underlying Kubernetes cluster. Currently only kind is support, other cloud providers
# should still work but this test framework has no special cases for those.
CLOUD_PROVIDER?=
Expand Down Expand Up @@ -177,6 +178,7 @@ endif
--fdb-image="$(FDB_IMAGE)" \
--sidecar-image="$(SIDECAR_IMAGE)" \
--operator-image="$(OPERATOR_IMAGE)" \
--data-loader-image=$(DATA_LOADER_IMAGE) \
--registry="$(REGISTRY)" \
--fdb-version="$(FDB_VERSION)" \
--cleanup=$(CLEANUP) \
Expand Down
Loading
Loading