Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for custom embedded folder and remove -d flag for daemon mode #67

Merged
merged 7 commits into from
Jan 20, 2025

Conversation

FilippoTrotter
Copy link
Collaborator

No description provided.

@FilippoTrotter FilippoTrotter requested a review from puria January 20, 2025 14:40
This was linked to issues Jan 20, 2025
Copy link
Member

@puria puria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this way, by passing directly a folder via build, makes it impossible to have different directories as a source of contracts.
I do still prefer to have a simple file, with the directories one per line... or if you prefer a json... whatever simple when you run go generate you copy all of them.

@puria
Copy link
Member

puria commented Jan 20, 2025

In this way, by passing directly a folder via build, makes it impossible to have different directories as a source of contracts. I do still prefer to have a simple file, with the directories one per line... or if you prefer a json... whatever simple when you run go generate you copy all of them.

Also if no directories as specified in this metadata extra_dir files, just the contract directory will be embedded. No need to have a different make build with extra arguments like dir={}

@puria puria merged commit 29678d6 into main Jan 20, 2025
3 checks passed
@puria puria deleted the embedding_folder branch January 20, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom contracts folder add checks for custom options
2 participants