New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a devcontainer configuration and set the Node.js version #226

Open

nedex wants to merge 2 commits into FoldingAtHome:main from nedex:feat_devcontainer

nedex commented Jan 17, 2025

This pull request adds a devcontainer configuration file which contains a basic Node.js environment with nvm.

I also noticed the following problems:

Lack of package-lock.json file (it should be included to help reproducibility)
- The use of npm ci instead of npm install should be encouraged
The Node.js version to use not specified (the .nvmrc file includes the node version to use)
The port specified on the README file is 3000 but it should be 5173

Tested working on Windows environment (using WSL2) and MacOS

nedex added 2 commits

January 17, 2025 16:41


          Add a devcontainer configuration and specify the node version along w…

f97ce9e

…ith fixed npm packages


          Fix wrong port in readme file

0077e03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet