fix: consistently strip HTML from tool input before JSON parsing #5151
+14
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The issue was that the Flowise UI was adding HTML/markdown formatting to JSON input fields, but the stripHTMLFromToolInput function was not being applied consistently to all JSON parsing operations. This caused:
JSON Parse Failures: When tools tried to parse input that contained HTML formatting
Inconsistent Behavior: Some fields worked while others failed
User Confusion: Valid JSON inputs were being rejected due to hidden formatting
Fix: The stripHTMLFromToolInput function:
Removes HTML formatting using TurndownService
Cleans up escaped characters that might interfere with JSON parsing
Returns clean text that can be safely parsed as JSON