Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the team instance creation page look more like a page #3930

Merged
merged 2 commits into from
May 28, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented May 24, 2024

Description

Made the instance form more embed-able friendly by adding the ability to hide it's title & heading.

Also removed center alignment of instance page and added a page header

Related Issue(s)

closes #3929

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.28%. Comparing base (2f654bf) to head (c65d363).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3930   +/-   ##
=======================================
  Coverage   79.28%   79.28%           
=======================================
  Files         281      281           
  Lines       12755    12755           
  Branches     2844     2844           
=======================================
  Hits        10113    10113           
  Misses       2642     2642           
Flag Coverage Δ
backend 79.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns self-assigned this May 27, 2024
@cstns cstns requested a review from joepavitt May 27, 2024 07:49
@cstns
Copy link
Contributor Author

cstns commented May 27, 2024

Did not add e2e tests as only cosmetic changes were made without impacting functionality

@cstns cstns force-pushed the 3929-alter-instance-creation-page branch from a71ca10 to 8b91feb Compare May 27, 2024 11:37
@cstns cstns changed the title make the instance creation page look more like a page make the team instance creation page look more like a page May 27, 2024
…uniform look when dealing with multiple blueprints
@joepavitt joepavitt merged commit c202138 into main May 28, 2024
13 checks passed
@joepavitt joepavitt deleted the 3929-alter-instance-creation-page branch May 28, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alter the Team Instance creation page to feel more like a page
2 participants