feat: add Open Cycle Maps #302
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bebablub
approved these changes
May 19, 2025
web/src/lib/components/trail/map_with_elevation_maplibre.svelte
Outdated
Show resolved
Hide resolved
|
I fixed the typo and added some docs how to set up the integration with thunderforest :) |
bebablub
reviewed
May 21, 2025
| @@ -16,5 +16,6 @@ ENV MEILI_URL=http://127.0.0.1:7700 | |||
| ENV PUBLIC_DISABLE_SIGNUP=false | |||
| ENV UPLOAD_USER= | |||
| ENV UPLOAD_PASSWORD= | |||
| ENV PUBLIC_THUNDERFOREST_API_KEY= | |||
There was a problem hiding this comment.
improvement: Would it make sense to set the key also in docker-compose?
|
Why not use the tiles from CyclOSM and avoid having to set up a Thunderforst API key? |
Good point thank you @schmic Was not aware that this map provider exists. It has more and detailed maps than open cycle map 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the possibility to set the map type to opencycle maps. It requires free registration at Thunderforest.
The API Key provided need to be set as environment variable: