Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BadFunctions/NoEvals: add unit tests + minor fix #73

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Mar 16, 2020

Related to #57, follow up on #70, this PR adds unit tests for the Security.BadFunctions.NoEvals sniff.

Commit Summary

BadFunctions/NoEvals: add unit tests

BadFunctions/NoEvals: error message precision

eval() is a language construct, not a function.

Ref: https://www.php.net/manual/en/function.eval.php

BadFunctions/NoEvals: remove redundant function call

$tokens is not used, so no need to declare it.

@jrfnl jrfnl force-pushed the feature/noevals-add-unit-tests branch from ea2d7bc to 171dc78 Compare March 16, 2020 06:08
@jrfnl jrfnl force-pushed the feature/noevals-add-unit-tests branch from 171dc78 to 0c57997 Compare March 16, 2020 06:12
@jrfnl
Copy link
Contributor Author

jrfnl commented Jun 18, 2020

Anything I can do to move this PR forward ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant