Skip to content

Check messages with regex. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Check messages with regex. #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 15 additions & 125 deletions bot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import os
import re
import traceback
from typing import Optional
from urllib.parse import quote as quote_url

import discord
Expand All @@ -11,7 +10,6 @@

from dotenv import load_dotenv
from logger import getLogger, set_global_logging_level
from curation_validator import get_launch_commands_bluebot, validate_curation, CurationType

set_global_logging_level('DEBUG')
l = getLogger("main")
Expand All @@ -32,6 +30,7 @@
GOD_USER = int(os.getenv('GOD_USER'))
NOTIFICATION_SQUAD_ID = int(os.getenv('NOTIFICATION_SQUAD_ID'))
BOT_GUY = int(os.getenv('BOT_GUY'))
MODERATOR_UPDATES_CHANEL = 1136365763582754866

intents = discord.Intents.default()
intents.members = True
Expand Down Expand Up @@ -66,7 +65,7 @@ async def on_message(message: discord.Message):
await bot.process_commands(message)
await forward_ping(message)
await notify_me(message)
await check_curation_in_message(message, dry_run=False)
await regex_message_warning(message)


@bot.event
Expand Down Expand Up @@ -115,134 +114,24 @@ async def notify_me(message: discord.Message):
await message.author.add_roles(notification_squad)


async def check_curation_in_message(message: discord.Message, dry_run: bool = True):
if len(message.attachments) != 1: # TODO can we have more than one attachment?
return

is_in_flash_game_channel = message.channel.id == FLASH_GAMES_CHANNEL
is_in_other_game_channel = message.channel.id == OTHER_GAMES_CHANNEL
is_in_animation_channel = message.channel.id == ANIMATIONS_CHANNEL
is_audition = message.channel.id == AUDITIONS_CHANNEL
# TODO disable
# is_curator_lounge = message.channel.id == CURATOR_LOUNGE_CHANNEL

if not (
is_in_flash_game_channel or is_in_other_game_channel or is_in_animation_channel or is_audition): # or is_curator_lounge):
return

attachment = message.attachments[0]
archive_filename: str = attachment.filename
if not (archive_filename.endswith('.7z') or archive_filename.endswith('.zip') or archive_filename.endswith('.rar')):
return

l.debug(
f"detected message '{message.id}' from user '{message.author}' in channel '{message.channel}' with attachment '{archive_filename}'")
l.debug(f"downloading attachment '{attachment.id}' - '{archive_filename}'...")
await attachment.save(archive_filename)

try:
curation_errors, curation_warnings, is_extreme, curation_type, _, _ = validate_curation(archive_filename)
except Exception as e:
l.exception(e)
l.debug(f"removing archive {archive_filename}...")
os.remove(archive_filename)
if not dry_run:
l.debug(f"adding 💥 reaction to message '{message.id}'")
await message.add_reaction('💥')
reply_channel: discord.TextChannel = bot.get_channel(BOT_TESTING_CHANNEL)
await reply_channel.send(f"<@{GOD_USER}> the curation validator has thrown an exception:\n"
f"🔗 {message.jump_url}\n"
f"```{traceback.format_exc()}```")
return

# archive cleanup
l.debug(f"removing archive {archive_filename}...")
os.remove(archive_filename)
if message.content == "":
curation_errors.append("Discord upload must include title of game.")
if not is_audition:
mentioned_channel: discord.TextChannel
if curation_type == CurationType.FLASH_GAME and not is_in_flash_game_channel:
mentioned_channel = bot.get_channel(FLASH_GAMES_CHANNEL)
curation_errors.append(f"Curation is a flash game, please submit to {mentioned_channel.mention}")
if curation_type == CurationType.OTHER_GAME and not is_in_other_game_channel:
mentioned_channel = bot.get_channel(OTHER_GAMES_CHANNEL)
curation_errors.append(f"Curation is an other game, please submit to {mentioned_channel.mention}")
if curation_type == CurationType.ANIMATION and not is_in_animation_channel:
mentioned_channel = bot.get_channel(ANIMATIONS_CHANNEL)
curation_errors.append(f"Curation is an animation, please submit to {mentioned_channel.mention}")

# format reply
final_reply: str = ""
if len(curation_errors) > 0:
final_reply += message.author.mention + f" Your curation is invalid:\n" \
f"🔗 {message.jump_url}\n"
if len(curation_errors) == 0 and len(curation_warnings) > 0:
final_reply += message.author.mention + f" Your curation might have some problems:\n" \
f"🔗 {message.jump_url}\n"

has_errors = len(curation_errors) > 0
if has_errors:
if not dry_run:
l.debug(f"adding 🚫 reaction to message '{message.id}'")
await message.add_reaction('🚫')
for curation_error in curation_errors:
final_reply += f"🚫 {curation_error}\n"

# TODO tag warnings changed to errors this way because i'm lazy for now
has_warnings = len(curation_warnings) > 0
if has_warnings:
if not dry_run:
l.debug(f"adding 🚫 reaction to message '{message.id}'")
await message.add_reaction('🚫')
for curation_warning in curation_warnings:
final_reply += f"🚫 {curation_warning}\n"

is_audition_with_mistakes = is_audition and (has_warnings or has_errors)
if is_audition_with_mistakes and "duplicate" not in final_reply:
final_reply += "Please fix these errors and resubmit."
elif is_audition_with_mistakes:
final_reply += "Feel free to curate another game instead."

if is_extreme and not dry_run:
l.debug(f"adding :extreme: reaction to message '{message.id}'")
emoji = bot.get_emoji(EXTREME_EMOJI_ID)
# This is just for testing on my server so I don't get an error, though it's also useful if we lose emoji slots
if emoji is None:
emoji = "🔞"
await message.add_reaction(emoji)

if len(final_reply) > 0:
# TODO tag warnings changed to errors this way because i'm lazy for now
# if len(curation_errors) == 0 and len(curation_warnings) > 0:
# final_reply += "⚠️ If the problems detected are valid and you're going to upload a fixed version, " \
# "please remove the original curation submission after you upload the new one."
reply_channel: discord.TextChannel = bot.get_channel(BOT_ALERTS_CHANNEL)
if is_extreme:
reply_channel = bot.get_channel(NSFW_LOUNGE_CHANNEL)
elif is_in_flash_game_channel or is_in_other_game_channel or is_in_animation_channel:
reply_channel = bot.get_channel(BOT_ALERTS_CHANNEL)
elif is_audition:
reply_channel = bot.get_channel(AUDITION_CHAT_CHANNEL)
if not dry_run:
l.info(f"sending reply to message '{message.id}' : '" + final_reply.replace('\n', ' ') + "'")
await reply_channel.send(final_reply)
else:
l.info(f"NOT SENDING reply to message '{message.id}' : '" + final_reply.replace('\n', ' ') + "'")
else:
if not dry_run:
l.debug(f"adding 🤖 reaction to message '{message.id}'")
await message.add_reaction('🤖')
l.info(f"curation in message '{message.id}' validated and is OK - {message.jump_url}")


def is_bot_guy():
async def predicate(ctx):
return ctx.author.id == BOT_GUY

return commands.check(predicate)


regex_pattern = re.compile(r'://(?!discord\.com)d[ils]{1,3}c[cos]?o[a-z]?r[a-z]{0,3}-?(app|e?g[a-z]{1,2}fts?|full|n[a-z]{1,2}tro[a-z]?|free|get|promo|verify|shop|store|click|give|drop)?\.', re.IGNORECASE)

async def regex_message_warning(message: discord.Message):
if message.author == bot.user:
return

if regex_pattern.search(message.content):
moderator_updates_channel: discord.TextChannel = bot.get_channel(MODERATOR_UPDATES_CHANEL)
await moderator_updates_channel.send(
f"Message by {message.author.display_name} matched guardian regex. \nLink: {message.jump_url}"
)

async def main():
# load cogs
Expand All @@ -256,5 +145,6 @@ async def main():
async with bot:
await bot.start(TOKEN)


if __name__ == "__main__":
asyncio.run(main())
asyncio.run(main())