fix: Frontend can crash if query string is invalid #5236
+12
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to load a URL with a malformed query string currently crashes the frontend. For example (note the extra
=
at the end):https://app.flagsmith.com/project/16945/environment/ihAHot7taBsh6hbHJKdYHs/features?is_archived=false&tag_strategy=INTERSECTION&page=1&search=&sortBy=name&sortOrder=asc=
Fails with:
At least one customer ran into this when using the ClearURLs Firefox add-on: https://addons.mozilla.org/en/firefox/addon/clearurls/
It's probably better to use a dedicated hook for accessing the query string instead of parsing it on every
fromParam
call, but this is a stop-gap solution to at least stop the frontend crashing.Tested by trying to load an equivalent URL locally.