Skip to content

Fix nullable parameter #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Conversation

VincentLanglet
Copy link
Contributor

Hi @matthewelwell

With PHP 8.4 we get deprecation like

Flagsmith\Flagsmith::__construct(): Implicitly marking parameters $apiKey, $host, $customHeaders, $environmentTtl, $retries, $defaultFlagHandler, and $offlineHandler as nullable is deprecated, the explicit nullable type must be used instead.

I try to solve all of them.

@matthewelwell
Copy link
Contributor

@VincentLanglet thanks for submitting this. The PR looks good to me. You'll need to rebase onto the main branch once #91 is merged and then we can get this merged in.

@matthewelwell
Copy link
Contributor

@VincentLanglet #91 was merged yesterday so you're good to rebase and fix the conflict, then we can get this merged. Thanks!

@VincentLanglet
Copy link
Contributor Author

Done @matthewelwell

@matthewelwell matthewelwell merged commit 2727927 into Flagsmith:main Mar 28, 2025
3 checks passed
@VincentLanglet
Copy link
Contributor Author

Hi @matthewelwell I'm not sure why but the 4.5.1 release is not present on composer
https://packagist.org/packages/flagsmith/flagsmith-php-client

@matthewelwell
Copy link
Contributor

@VincentLanglet one day I'll remember to bump the version in composer.json (or we'll eventually integrate release please into this repo!).

Sorry, it should be there now (or very soon) - I've recreated the release after bumping the version in #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants