Skip to content

Add ext-json as requirement #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add ext-json as requirement #84

wants to merge 1 commit into from

Conversation

VincentLanglet
Copy link
Contributor

Hi @matthewelwell

\JsonSerializable is used and json_ methods too, so it should be a requirement in the composer.json.

@VincentLanglet VincentLanglet mentioned this pull request Sep 10, 2024
Closed
@matthewelwell
Copy link
Contributor

As I understand it, ext-json is not needed for PHP8+ as per the conversation here.

@VincentLanglet
Copy link
Contributor Author

Indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentLanglet @matthewelwell