Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parser for native toJSON formats #45

Merged
merged 16 commits into from
Nov 17, 2023
Merged

Add parser for native toJSON formats #45

merged 16 commits into from
Nov 17, 2023

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Nov 17, 2023

This adds response parsers for the recently-added toJSON() response formats.

Progress towards #41, which will be completed when there's message generators that complement the PublicKeyCredential.parse{Creation|Request}OptionsFromJSON() methods.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (267d04a) 79.37% compared to head (e8ef6f2) 80.56%.

Files Patch % Lines
src/BinaryString.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #45      +/-   ##
============================================
+ Coverage     79.37%   80.56%   +1.18%     
- Complexity      170      199      +29     
============================================
  Files            24       25       +1     
  Lines           548      597      +49     
============================================
+ Hits            435      481      +46     
- Misses          113      116       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Firehed Firehed changed the title Lv3 formats Add parser for native toJSON formats Nov 17, 2023
@Firehed Firehed marked this pull request as ready for review November 17, 2023 18:49
@Firehed Firehed merged commit efccbdf into main Nov 17, 2023
10 checks passed
@Firehed Firehed deleted the lv3-formats branch November 17, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant