fix(windows build): Use correct variable to specify target architecture when calling vcvarsall.bat
#8765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re when calling `vcvarsall.bat`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I can see, in order to build a server for
x32onx64machine, the variableFB_PROCESSOR_ARCHITECTUREis set tox32before callingrun_all.bat, butPROCESSOR_ARCHITECTUREis used in the call tovcvarsall.bat(to set environment variables).Currently, this does not cause any problems. However, if a third-party library uses, for example,
cl.exeto build itself, incorrect environment variables will cause problems.