Fix MSVC C4146 warnings #8366
Open
Fix MSVC C4146 warnings #8366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning description: "unary minus operator applied to unsigned type, result still unsigned".
dyemanov
approved these changes
Dec 27, 2024
dyemanov
reviewed
Dec 28, 2024
| @@ -432,7 +432,7 @@ void FirstValueWinNode::aggInit(thread_db* tdbb, Request* request) const | |||
|
|
|||
| dsc* FirstValueWinNode::winPass(thread_db* tdbb, Request* request, SlidingWindow* window) const | |||
| { | |||
| if (!window->moveWithinFrame(-(window->getRecordPosition() - window->getFrameStart()))) | |||
| if (!window->moveWithinFrame(-static_cast<SINT64>(window->getRecordPosition() - window->getFrameStart()))) | |||
There was a problem hiding this comment.
I\d suggest a temporary variable for better readability, e.g.:
const SINT64 offset = window->getRecordPosition() - window->getFrameStart(); // with static_cast, if necessary
if (!window->moveWithinFrame(-offset))
There was a problem hiding this comment.
Expression window->getRecordPosition() - window->getFrameStart() used many times, makes sence to move it into separate function, like:
class SlidingWindow
{
public:
...
FB_UINT64 getInFrameOffset() const
{
return savedPosition - frameStart;
}
Perhaps, it should return SINT64
| @@ -583,7 +583,7 @@ dsc* NthValueWinNode::winPass(thread_db* tdbb, Request* request, SlidingWindow* | |||
| const SLONG fromPos = desc ? MOV_get_long(tdbb, desc, 0) : FROM_FIRST; | |||
|
|
|||
| if (fromPos == FROM_FIRST) | |||
| records += -(window->getRecordPosition() - window->getFrameStart()) - 1; | |||
| records += -static_cast<SINT64>(window->getRecordPosition() - window->getFrameStart()) - 1; | |||
There was a problem hiding this comment.
Maybe just -= with a positive offset here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning description: "unary minus operator applied to unsigned type, result still unsigned".