Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firestore admin #92

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

leovigna
Copy link

@leovigna leovigna commented Nov 6, 2023

I needed support for RxJs using FirebaseAdmin due to writing reactive code server side.
I saw this issue was brought up in the past #38

I have made a basic port for rxfire/firestore to support firestore-admin under rxfire/firestore/admin (similar to lite implementation).
The logic is essentially the same but has the following changes:

  • use firebase-admin apis
  • remove comparison with cache data since not applicable to firebase-admin
  • remove SnapshotOptions (serverTimestamps) as not applicable to firebase-admin

I have also added a test suite that is similar to the existing one (though removed the converter tests as couldn't find documentation relating to this.

Please let me know if this PR is welcome and if there are any changes I should make to it.

Copy link

google-cla bot commented Nov 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant