feature: Next.js e-commerce template #292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emwp
requested review from
jamesdaniels,
leoortizz,
Yuangwang and
tonyjhuang
as code owners
leoortizz
reviewed
Jan 15, 2025
Comment on lines
+31
to
+32
| # vercel | ||
| .vercel |
There was a problem hiding this comment.
Suggested change
| # vercel | |
| .vercel |
jamesdaniels
reviewed
Feb 6, 2025
| } | ||
| } | ||
|
|
||
| query GetOrdersByCustomerId($customerId: String!) @auth(level: PUBLIC) { |
There was a problem hiding this comment.
Can we lock this down by auth.id? Same with getorder
jamesdaniels
reviewed
Feb 6, 2025
| ) | ||
| } | ||
|
|
||
| mutation CreateOrder( |
There was a problem hiding this comment.
create and update order need to be authenticated
jamesdaniels
reviewed
Feb 6, 2025
| @@ -0,0 +1,114 @@ | |||
| mutation UpsertCustomer( | |||
jamesdaniels
reviewed
Feb 6, 2025
| const cookieStore = await cookies() | ||
| const session = cookieStore.get('__session')?.value | ||
|
|
||
| if (session) { |
There was a problem hiding this comment.
we should do real auth here, you can see the latest on how to accomplish this in nextjs in the updates I made to our codelab https://github.com/firebase/friendlyeats-web/blob/bffaeae7647f7ea61b4a369a9567881cb8183e8c/nextjs-end/src/components/Header.jsx#L12
jamesdaniels
requested changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Next.js E-commerce Template
Description
This PR adds a new
nextjs/firebase-ecommercetemplate to demonstrate building a full-featured e-commerce application using Next.js and Firebase services. This template showcases real-world implementation patterns and Firebase integration best practices.Key Features
Firebase Services Utilized
Implementation Details:
The template follows the same structure as our existing basic Next.js starter (referenced in
starters/nextjs/basic) but adds e-commerce specific features and Firebase service integrations. It maintains compatibility with Firebase App Hosting's configuration-free deployment process.Testing