Effectively removing pagination for changelist view. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aiky30
requested changes
Mar 25, 2022
adam-murray
approved these changes
Mar 28, 2022
Aiky30
requested changes
Mar 28, 2022
| @@ -56,6 +57,9 @@ | |||
| using_version_lock = False | |||
| LOCK_MESSAGE = _("You don't have permission to change this item") | |||
|
|
|||
| # This setting is used to effectively disable django pagination for MenuItem changelist view: | |||
| MAX_RESULTS_PER_PAGE = getattr(settings, "MAX_RESULTS_PER_PAGE", sys.maxsize) | |||
There was a problem hiding this comment.
@marktsavage The settings need to be in a separate file: conf.py, this is consistent with the cms ecosystem.
The setting will also be prefixed with the package name, something like: CMS_NAVIGATION_TREE_MAX_RESULT_COUNT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled the pagination in MenuItem changelist view by setting the list_per_page to max value. This was desired to allow the full result set to display on one page.