fixed issue with java 10 not being able to find javafx ant jar #128
Conversation
… relative path issue
|
This looks good |
|
why is this not merged? |
|
ok, I understand why you don't want to add new features |
|
I understand you're working on a new project to supersede this one but this one is still useful until then. I'd recommend to just accept the PR and merge to master. Nothing much you gotta do on your part to make this somewhat usable again to Java 10 (new LTS) users. |
|
@dantheman213 if @FibreFoX agrees to do one more release could you modify this PR to apply my suggestion from above? |
What is the point, as it will not work with Java 11 which has removed JavaFX and the javapackager. |
|
@DJViking wasn't aware of that, ignore my last comment then |
|
The next LTS-versions seems to be JDK 11, not the JDK 10 one which this plugin requires because of the bundler AND the native launcher files including the whole detection and preparation stuff inside that tiny little Thats why I'm starting to drain updates to this plugin, even if it hurts the community. And please keep in mind, that this project is a one-person while his spare-time project. My personal life was already heavily influenced by taking a lot of time for supporting the community, which currently is not available. Creating some open-source project can sometimes get very toxic on the maintenance-side, a lot of people wanting to have their problems fixed (in short time, for free, with all things kept in mind and without any type of sacrifices to make with the upcoming solution). My food-bringing job in the last years was WEB-development and mostly java-backend stuff, no colleague nor anyone in my company was using JavaFX-technology, nor do I use JavaFX in my current new job (which is now being mobile application development as one main part). So please do understand my position here: I'm not happy with not having the time or energy to fully support this project, not because I'm some evil person that wants you all to suffer, but when the leaders of the JDK (regardless of OracleJDK or OpenJDK) decided to drop that these for this project important pieces which made this plugin usable (this point is valid for the maven-equivalent), I somewhat felt thrown into a giant hole of missing pieces to complete the puzzle. I'm not happy with that rapid releasement process of the JDK, because it's a maintenance hell, for developers, system-operators and especially for tooling-creators like me. That is why I decided to start that other spare-time side project which I am working on in the meantime (researching for the then missing launcher part, making it usable for non-JavaFX applications too, being able to have a complete build-pipeline, having a very easy way to customize these native launchers, and so on and so on). Let me make it clear: I need some time to recharge my batteries, and it takes longer that I'm wanting it to take. |
|
Danny: What are you using in your other plugin to create a native package? |
|
While I do get that some projects simply depend on Java 10 to build, other projects mightn't. I was able to get around my issue with missing JavaFX in Java 10 by using jabba - Java Version Manager After installing I simply went You can also use |
|
This still hasn't been merged? Has the project been superseded with something better yet? |
|
Still open huh? :( |
|
@dantheman213 Did you give my quickfix solution a spin? |
There was an issue where if you had JAVA 10 JDK installed on Windows the ../lib relative path wasn't to be found in JAVA_HOME and your app throws a GradleException error. This is fixing that because in Java 10 the lib/ dir is NOT outside the JDK folder.. it sits inside it. This PR should fix the issue.