Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional progress bar to Sequence #79

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jdpigeon
Copy link
Contributor

@jdpigeon jdpigeon commented Apr 1, 2020

I thought it would be nice for the library to have an easy-to-use progress bar like jspsych has. I went ahead and made same changes to the Sequence in class in order to achieve that in this PR.

I'm not sure if adding this directly to Sequence is this best idea as this will break if the user tries to nest progress bars. Maybe it could be added to the global Lab.js 'engine'?

Also, I was pretty shocked to put this whole thing together and then find some CSS styles for a progress bar! I didn't see anywhere in the library where these would be applied, so I'm curious what the story is.

Cheers, and let me know what I can do to tidy this up.

@FelixHenninger
Copy link
Owner

Oh, apologies for the force-push! 😬

Base automatically changed from master to main January 19, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants