chore: disable emulated backlight by default since it is buggy.

Signed-off-by: Federico Di Pierro <[email protected]>
FedeDP · Nov 4, 2023 · 7d447d0 · 7d447d0
1 parent f94977e
commit 7d447d0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/TODO.md b/TODO.md
@@ -1,11 +1,9 @@
-## 5.x
+## 5.9
 
 ### Als
 - [x] add support for buffer als reads
 
 ### Pipewire
-- [ ] Fix set_camera_setting() impl -> how to get current value? how to set a new value?
-- [ ] Check pipewire 0.3.60 v4l2 changes 
 - [x] fix source of segfault
 - [x] fix node names, ose object.path instead of object id 
 - [x] use same algorithm as camera sensor to retrieve default camera (ie: the one with highest USEC_INITIALIZED property)
@@ -15,6 +13,16 @@
 - [x] use USEC_INITIALIZED property instead of sysnum
 
 ### Backlight
+- [x] disable emulated_backlight by default since it is a little buggy
+
+## 5.x
+
+### Pipewire
+- [ ] Fix set_camera_setting() impl -> how to get current value? how to set a new value?
+- [ ] Check pipewire 0.3.60 v4l2 changes 
+
+### Backlight
+- [ ] investigate emulated_backlight bugginess
 - [ ] Keep it up to date with possible ddcutil api changes
 
 ## 6.0 (api break)

diff --git a/src/modules/backlight_plugins/ddc.c b/src/modules/backlight_plugins/ddc.c
@@ -25,7 +25,7 @@ BACKLIGHT("DDC");
 static struct udev_monitor *drm_mon;
 static DDCA_Vcp_Feature_Code br_code = 0x10;
 static bool ddc_backlight_enabled = true;
-static bool emulated_backlight_enabled = true;
+static bool emulated_backlight_enabled = false;
 static uint64_t curr_cookie;
 
 static bool load_env(void) {