Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add between rule #334

Merged
merged 1 commit into from
Sep 19, 2023
Merged

feat: add between rule #334

merged 1 commit into from
Sep 19, 2023

Conversation

frankzhaopeng
Copy link
Member

Fix #328

Changes proposed in this pull request:

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #334 (271dbd2) into main (ae74648) will decrease coverage by 0.62%.
Report is 14 commits behind head on main.
The diff coverage is 45.03%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #334      +/-   ##
============================================
- Coverage     63.68%   63.07%   -0.62%     
  Complexity      593      593              
============================================
  Files           175      175              
  Lines          5326     5397      +71     
  Branches        683      714      +31     
============================================
+ Hits           3392     3404      +12     
- Misses         1755     1814      +59     
  Partials        179      179              
Flag Coverage Δ *Carryforward flag
api_ut 53.31% <ø> (ø) Carriedforward from ae74648
server 69.51% <ø> (ø) Carriedforward from ae74648
ui 90.11% <45.03%> (-4.63%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
ui/src/components/Rule/condition.tsx 63.13% <31.31%> (-23.74%) ⬇️
ui/src/components/Diff/RulesDiffContent.tsx 89.50% <86.20%> (-1.83%) ⬇️
ui/src/components/Rule/constants.tsx 100.00% <100.00%> (ø)

@frankzhaopeng frankzhaopeng merged commit 8396d21 into main Sep 19, 2023
9 of 13 checks passed
@frankzhaopeng frankzhaopeng deleted the feature-condition-between branch September 19, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

增加一个区间规则
1 participant