Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for csharp namespace in protobuf schemas #560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

esskar
Copy link
Contributor

@esskar esskar commented Apr 17, 2024

Description

This pull request enhances the ConfluentProtobufTypeNameResolver to respect the csharp_namespace option specified in protobuf files when resolving type names from the Confluent Schema Registry. Previously, the resolver did not consider this option and only used the protobuf package to construct the resolved name. This change ensures better compatibility with C# namespaces and avoids potential conflicts in projects using custom namespaces.

Fixes #229

How Has This Been Tested?

  • Unit Tests: Added unit tests to check whether the resolver correctly handles protobuf files with and without the csharp_namespace option.
  • Manual Testing: Manually tested the changes in a .NET application to ensure that the resolved names are correctly used in the context of message serialization and deserialization.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

In Protobuf messages the "option csharp_namespace ..." attribute is ignored
1 participant