-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated link #223
Updated link #223
Conversation
@@ -0,0 +1,5 @@ | |||
[ | |||
"http://localhost:3000", |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
@@ -0,0 +1,5 @@ | |||
[ | |||
"http://localhost:3000", | |||
"http://otherserver:3000", |
Check warning
Code scanning / devskim
An HTTP-based URL without TLS was detected. Warning
[ | ||
"http://localhost:3000", | ||
"http://otherserver:3000", | ||
"http://anotherserver:3000" |
Check warning
Code scanning / devskim
An HTTP-based URL without TLS was detected. Warning
@@ -150,6 +154,10 @@ | |||
|
|||
async fn add_player(&self, player: Player) -> Result<()> { | |||
let mut players = self.players.lock().await; | |||
|
|||
// TODO Add player to struct. Eventually we will make the server connections global for lower resource usage |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
press the approve button apparently
Plugin Enhancements:
serde_json
,rust_socketio
, andlazy_static
inCargo.toml
to support JSON serialization, socket communication, and static initialization, respectively.Listner
struct to include aservers
field for managing socket connections and implemented a new constructor to initialize connections based onlink_config.json
.on
method in theListner
struct to forward events to all connected servers, ensuring data synchronization across the network.Server Module Updates:
Listner
struct into the server module by importing it and initializing it when a new player is added. This allows the server to manage player connections and forward events. [1] [2]HorizonThread
initialization to include loading thelink_plugin
, ensuring the plugin is ready to handle events and connections.Configuration Changes:
link_config.json
to store server addresses, which are read during the initialization of theListner
struct to establish connections.