-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working towards 0.13.0 #195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a about the game world
… generate a thread as we cant Impl Drop for Plugin externally)
Co-authored-by: Tristan Poland (Trident_For_U) <[email protected]>
|
||
if let Err(e) = socket.emit("auth", &data) { | ||
log_error!(LOGGER, "SOCKET NET", "Failed to send auth: {}", e); | ||
return; | ||
} | ||
|
||
// TODO: Implement proper thread management via round robin |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
Suspicious comment
Co-Authored-By: Nils Kristians Ramps-Rampans <[email protected]>
Co-Authored-By: Nils Kristians Ramps-Rampans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the server configuration and initialization process, as well as some cleanup and refactoring. We will be updating this as we progress to
V 0.13.0
Removal of
dhat
profiler:dhat
dependency fromCargo.toml
.dhat
global allocator and profiler initialization frommain.rs
Updates to server configuration:
address
andport
fields toServerConfig
struct inconfig.rs
.server_config.json
to includeaddress
andport
fields.Modifications to server initialization:
ServerConfig
usage to useArc
for shared ownership inmod.rs
address
andport
fromServerConfig
and bind to the full addressCleanup:
server_config.json
file.Other 0.13.0 tasks (this is the full list of tasks so some were completed outside of this PR)
Done
unwarp()
s have been removed and error handling was improved dramatically, Horizon can officially no longer crashNot done (These will have a PR and branch of their own)