Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ForgeMixinDatagenModLoader to fix conflict with Create/Fusion/others #706

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

object-Object
Copy link
Member

Fixes #620.

Supersedes #621 - it seems like datagen and the mod itself both work fine without this mixin being present at all. I've confirmed that the crash with Fusion does not occur with this change.

Copy link
Member

@SamsTheNerd SamsTheNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine.

summary from DMs for future reference: nobody knows what this mixin was for, issues go away when it's gone and everything works. If we find out we need it in the future gate it with a mixin plugin.

@object-Object object-Object merged commit 1421976 into main Jul 23, 2024
4 checks passed
@object-Object object-Object deleted the fix-datagen-mixin-conflict branch July 23, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[1.20.1] Mod incompatibility with Fusion causing crash with Create and potentially others
2 participants