A variety of small bugfixes #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he square root of a negative number
…by defaulting all readable items to read NullIota() if no iota contained. Fixed behaviour of OpRead and similar if no IotaHolder found.
…umptionPriority.
…from things with nothing in them), remove references to Hands in places where they aren't needed.
…adding a writeable() method to IotaHolderItem.
…ackets unnecessarily, getting names of patterns for every cast and only using if a mishap occurs)
… enough for that to be fine.
… longer triggering.
|
Merge conflict needs resolving, apparently |
This was
linked to
issues
Mar 25, 2024
Closed
5 tasks
SamsTheNerd
requested changes
Aug 2, 2024
Common/src/main/java/at/petrak/hexcasting/api/casting/mishaps/MishapBadOffhandItem.kt
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/common/items/storage/ItemThoughtKnot.java
Outdated
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/common/items/storage/ItemFocus.java
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/common/casting/arithmetic/DoubleArithmetic.kt
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/common/casting/actions/spells/OpPlaceBlock.kt
Outdated
Show resolved
Hide resolved
SamsTheNerd
approved these changes
Aug 2, 2024
object-Object
requested changes
Aug 12, 2024
Common/src/main/java/at/petrak/hexcasting/api/casting/mishaps/MishapBadOffhandItem.kt
Outdated
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/common/casting/actions/rw/OpWrite.kt
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/common/casting/arithmetic/DoubleArithmetic.kt
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/common/items/storage/ItemFocus.java
Show resolved
Hide resolved
Common/src/main/java/at/petrak/hexcasting/common/items/storage/ItemFocus.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing several issues listed below, and a number of other issues that don't (I think) have issue trackers since I noticed them as I was fixing known issues.
Fix #608, fix #585, fix #551, fix #545, fix #541, fix #515, fix #513