pass bounded record to cartesian product branches #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AviAvni
requested changes
Nov 8, 2023
src/execution_plan/ops/op_apply.c
Outdated
| op->records = array_new(Record, 1); | ||
| op->rhs_branch = opBase->children[1]; | ||
| op->bound_branch = opBase->children[0]; | ||
|
|
||
| // locate branch's Argument op tap | ||
| op->op_arg = (Argument *)ExecutionPlan_LocateOp(op->rhs_branch, | ||
| op->args = array_new(Argument*, 1); |
There was a problem hiding this comment.
get the op argements from the constructor
and add test for nested apply
There was a problem hiding this comment.
It would be wise to make this same change to all of our Apply variations e.g. OR/AND Apply Multiplexer, Semi Apply and Anti Semi Apply.
The only possible issue I see with this request is identifying the taps at compile time, there might be run-time changes which modify the Argument taps (still needs to be verified).
src/execution_plan/ops/op_apply.h
Outdated
| OpBase *rhs_branch; // right-hand branch | ||
| Argument *op_arg; // right-hand branch tap | ||
| Record r; // bound branch record | ||
| Record *records; // LHS records |
| _ExecutionPlan_ParentReplaceChild(op->parent, op, op->children[0]); | ||
| // Add each of op's children as a child of op's parent. | ||
| for(int i = 1; i < op->childCount; i++) _OpBase_AddChild(parent, op->children[i]); | ||
| if(parent != NULL) { |
| } else { | ||
| // Remove op from its parent. | ||
| _OpBase_RemoveChild(op->parent, op); | ||
| ASSERT(op->childCount == 1); |
There was a problem hiding this comment.
remove this assumption and disconnect the parent from all children
| ExecutionPlan_AddOp(cp, branch); | ||
|
|
||
| if(bounded) { | ||
| OpBase *arg = NewArgumentOp(plan, vars); |
There was a problem hiding this comment.
collect this op_argumets and pass to the op_apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bound variables should be available to cartesian product branches
This PR uses the
ApplyandArgumentoperations to pass records into the cartesian-product branches.