Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The compare subcommand #1

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

The compare subcommand #1

wants to merge 3 commits into from

Conversation

GrizzlT
Copy link
Member

@GrizzlT GrizzlT commented Jul 1, 2022

This subcommand should be able to compare two data versions (block data for now).

A few requirements:

  • one directional comparison (i.e. from a version to another version)
  • easy to read summary of the incompatibilities
  • interactive menu for specifying compatibility fixes (although I think it's better if that was done in a different pr, feels like a separate topic to me)

First gonna figure out the ways block data can cause incompatibilities and list these here as well.

GrizzlT added 3 commits July 1, 2022 10:02
- list missing blocks
- check property compatibility of separate block entries
@GrizzlT GrizzlT self-assigned this Jul 4, 2022
@GrizzlT
Copy link
Member Author

GrizzlT commented Jul 4, 2022

First tests are promising. Forward compatibility is (as expected) quite well. Backwards compatibility seems a lot harder, evidently because of additions in later versions. Interesting, however, is that the number of individual block conflicts appears to be really low when compared to the amount of blocks. From 1.17.1 to 1.13, only 14 out of 590 blocks (excluding missing blocks) cannot be automatically matched between the two versions. I see this as a great confirmation this project can get somewhere real.

Next step would be specifying a format to list compatibility fixes in that would lead to maximum overlap between two versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant