lib, vtysh: fix 'show ip[v6] access-list ... json' formatting

[piotrsuchy]

Similarly to recently fixed 'show ip[v6] prefix-list ...' - PR#15750, json output is not valid for 'show ip[v6] access-list ... json' commands, as it goes through all the running daemons and for each one it calls 'filter_show' creating a new json object. To aggreagate the output and create a valid json that can later be parsed, the commands were moved to vtysh and formatted accordingly

Before and after for json objects the same as here: PR#15750

[ton31337]

Could you also provide a topotest (in additional PR is also good) that verifies JSON integrity/validity for prefix-list, access-list, route-map (per-daemon).

[piotrsuchy]

Ok, I will prepare a topotest (in a separate PR, since I'm not sure when I'll have time for that) -> should be something simple like one frr instance, setting arbitrary ip prefix-list, ip access-list and route-map rules in configuration and later passing the whole output through a json validator / linter, right?

[ton31337]

Yes

[ton31337]

ci:rerun CI stuck

[riw777]

looks good

[ton31337]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[ton31337]

@piotrsuchy could you fix also the failing test?

diff --git a/tests/topotests/nb_config/test_nb_config.py b/tests/topotests/nb_config/test_nb_config.py
index 8def19ffd5..9099ef10b8 100644
--- a/tests/topotests/nb_config/test_nb_config.py
+++ b/tests/topotests/nb_config/test_nb_config.py
@@ -50,7 +50,7 @@ def test_access_list_config_ordering(tgen):
     output = r1.vtysh_cmd("show ip access-list test json")
     got = json.loads(output)
     expected = json.loads(
-        '{"ZEBRA":{"test":{"type":"Standard", "addressFamily":"IPv4", "rules":[{"sequenceNumber":1, "filterType":"permit", "address":"10.0.0.1", "mask":"0.0.0.0"}]}}}'
+        '{"zebra":{"test":{"type":"Standard", "addressFamily":"IPv4", "rules":[{"sequenceNumber":1, "filterType":"permit", "address":"10.0.0.1", "mask":"0.0.0.0"}]}}}'
     )
     result = json_cmp(got, expected)
     assert result is None
@@ -63,7 +63,7 @@ def test_access_list_config_ordering(tgen):
     output = r1.vtysh_cmd("show ip access-list test json")
     got = json.loads(output)
     expected = json.loads(
-        '{"ZEBRA":{"test":{"type":"Zebra", "addressFamily":"IPv4", "rules":[{"sequenceNumber":1, "filterType":"permit", "prefix":"10.0.0.0/8", "exact-match":false}]}}}'
+        '{"zebra":{"test":{"type":"Zebra", "addressFamily":"IPv4", "rules":[{"sequenceNumber":1, "filterType":"permit", "prefix":"10.0.0.0/8", "exact-match":false}]}}}'
     )
     result = json_cmp(got, expected)
     assert result is None

[riw777]

most recent failure looks like

AssertionError: Expected padded packet with length 1497, got packet with length 97 assert 'Expected padded packet with length 1497, got packet with length 97' is True

not certain why this is related, trying to rerun just that test