pimd: Fix PIM MLAG Update Peer Zebra Status Upon Local MLAG Connectio… #15918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Restoration Issue: In scenarios where the local MLAG connection is down, we currently halt processing peer MLAG messages. However, upon restoration of the local connection, we fail to update the peer Zebra status accordingly. Consider the case where the peer is up and sends FRR status messages to the local node. If CLAGd restarts on the local node while FRR is running, the local CLAGd assumes the peer is still down even when it's up. Fix: Update the peer Zebra status once the local MLAG connection is restored Testing: UT Ticket: # Signed-off-by: Rajesh Varatharaj <[email protected]>
routingrocks
force-pushed
the
rvaratharaj/pim_mlag_state_fix
branch
from
2e85117
to
b45ff52
Compare
ton31337
requested changes
May 4, 2024
| return 0; | ||
| } | ||
|
|
||
|
|
| @@ -575,7 +587,6 @@ static void pim_mlag_process_mlagd_state_change(struct mlag_status msg) | |||
| return; | |||
| } | |||
| ++router->mlag_stats.msg.mlag_status_updates; | |||
|
|
|||
| zlog_debug( | ||
| "%s: update Mlag flag with PIM_MLAGF_PEER_ZEBRA_UP", | ||
| __func__); | ||
| router->mlag_flags |= PIM_MLAGF_PEER_ZEBRA_UP; |
| @@ -552,6 +552,18 @@ static inline void pim_mlag_vxlan_state_update(void) | |||
|
|
|||
|
|
|||
| /********************API to process PIM MLAG Data ************************/ | |||
| static void pim_mlag_peer_zebra_flag_set(void) | |||
| { | |||
| if (router->mlag_flags & PIM_MLAGF_PEER_CONN_UP) { | |||
| static void pim_mlag_peer_zebra_flag_set(void) | ||
| { | ||
| if (router->mlag_flags & PIM_MLAGF_PEER_CONN_UP) { | ||
| if (!(router->mlag_flags & PIM_MLAGF_PEER_ZEBRA_UP)) { |
| @@ -552,6 +552,18 @@ static inline void pim_mlag_vxlan_state_update(void) | |||
|
|
|||
|
|
|||
| /********************API to process PIM MLAG Data ************************/ | |||
| static void pim_mlag_peer_zebra_flag_set(void) | |||
There was a problem hiding this comment.
The naming is ambiguous... It says flag set, but it's not clear what flag. IMO the naming should be clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n Restoration
Issue:
In scenarios where the local MLAG connection is down, we currently halt processing peer MLAG messages. However, upon restoration of the local connection,
we fail to update the peer Zebra status accordingly.
Consider the case where the peer is up and sends FRR status messages to the local node. If CLAGd restarts on the local node while FRR is running, the local CLAGd assumes the peer is still down even when it's up.
Fix:
Update the peer Zebra status once the local MLAG connection is restored
Testing: UT
Ticket: #
Signed-off-by: Rajesh Varatharaj [email protected]