Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting photoz argument default to True #196

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Setting photoz argument default to True #196

merged 3 commits into from
Feb 18, 2025

Conversation

tarraneh
Copy link
Collaborator

Automatically pulls photo-zs for PS1 and adds them to the PATH candidates table.

Note that this REQUIRES a MAST user account: https://mastweb.stsci.edu/mcasjobs/CreateAccount.aspx
And for MAST_CASJOBS_USER and MAST_CASJOBS_PWD environment variables to be set.

@tarraneh tarraneh requested a review from SunilSimha January 22, 2025 16:16
Copy link
Collaborator

@SunilSimha SunilSimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 155's raise clause, I'd add an additional sentence for those who don't want to draw photoz's. e.g. "You need to ... get your credentials. Or set photoz=False in get_catalog."

Copy link
Collaborator

@SunilSimha SunilSimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@tarraneh tarraneh merged commit 39e0c5d into main Feb 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants