Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor the code #45

Merged
merged 23 commits into from
Jul 1, 2023
Merged

refactor: refactor the code #45

merged 23 commits into from
Jul 1, 2023

Conversation

cjhw
Copy link
Contributor

@cjhw cjhw commented Jul 1, 2023

No description provided.

@vercel
Copy link

vercel bot commented Jul 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doctor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2023 5:23am

Copy link
Member

@BoyYangzai BoyYangzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/npm-pkg/src/commands/npm-pkg.ts Show resolved Hide resolved
packages/utils/src/common.ts Outdated Show resolved Hide resolved
@BoyYangzai
Copy link
Member

可以用

//----------------------------- Source ---------------------------------

来划分不同逻辑的代码
common 这个 util 文件可能后面会有点大 可以这样区分
这是一个很好的 代码习惯

Copy link
Member

@BoyYangzai BoyYangzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@BoyYangzai BoyYangzai merged commit e03423a into FE-Struggler:master Jul 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants