Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kernel_vpp_ipsec.c #1089

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

Update kernel_vpp_ipsec.c #1089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update kernel_vpp_ipsec.c 
There was an issue in del_sa function where if there is no SA found due to any reason then it would fall into error label where it would try to free mp memory which get allocated later down in this function.
@inderpalpatheja
inderpalpatheja authored Jan 20, 2025
commit f2335b7840b645154de426ec6f5f77d6ef162675
3 changes: 2 additions & 1 deletion extras/strongswan/vpp_sswan/kernel_vpp_ipsec.c
View file
Original file line number Diff line number Diff line change
@@ -1795,7 +1795,8 @@ METHOD (kernel_ipsec_t, del_sa, status_t, private_kernel_vpp_ipsec_t *this,
{
DBG1 (DBG_KNL, "SA not found");
rv = NOT_FOUND;
goto error;
this->mutex->unlock (this->mutex);
return rv;
}
mp = vl_msg_api_alloc (sizeof (*mp));
memset (mp, 0, sizeof (*mp));