Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to links in external objects table #171

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alahiff
Copy link
Collaborator

@alahiff alahiff commented Oct 12, 2021

At the moment using the file symbol because the nice info symbol is only in the pro version of font awsome. If anyone has any alternative preferences (see https://fontawesome.com/v5.15/icons?d=gallery&p=2) please let me know.

@alahiff alahiff linked an issue Oct 12, 2021 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #171 (8015b0b) into main (0570eaa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   58.87%   58.87%           
=======================================
  Files          20       20           
  Lines        1223     1223           
=======================================
  Hits          720      720           
  Misses        503      503           
Flag Coverage Δ
unittests 58.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
data_management/tables.py 14.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0570eaa...8015b0b. Read the comment docs.

@alahiff
Copy link
Collaborator Author

alahiff commented Oct 12, 2021

We could also do the same for data products (link is now on the name) and code repo releases (link also on the name) so that everything is consistent.

@alahiff
Copy link
Collaborator Author

alahiff commented Oct 12, 2021

This is what it currently looks like:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't use Alternate Identifier as link to external object details
1 participant