Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix little bugs #1403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix little bugs #1403

wants to merge 1 commit into from

Conversation

zhang-shengping
Copy link
Contributor

cause error log: AttributeError: "'NoneType' object has no attribute 'find_subnet_route_domain'"

fixs:
self.network_helper none problem
delete extra '"""'

Niklaus-xie
Niklaus-xie requested changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@Niklaus-xie Niklaus-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine. but perhaps not rush to merge this for now. since we might revert the original one. so perhaps integrate those 2 commits into one later. put a -2 here for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Niklaus-xie Niklaus-xie Niklaus-xie requested changes

@zongzw zongzw zongzw approved these changes

@zhaoqin-github zhaoqin-github Awaiting requested review from zhaoqin-github

@jikui jikui Awaiting requested review from jikui

@olvandeng olvandeng Awaiting requested review from olvandeng

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhang-shengping @zongzw @Niklaus-xie