Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear all form data before updating hardware setting #2780

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

Ncerzzk
Copy link
Contributor

@Ncerzzk Ncerzzk commented Jun 13, 2024

For now, if we upload a new pin.json file, it will not clear the old form data in html.

which would cause pin config leaving over conflict to new pin setting.

Copy link
Collaborator

@pkendall64 pkendall64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just this...

  _('upload_hardware').reset();

@Ncerzzk Ncerzzk force-pushed the clear_hardware_before_upload branch from 319fb15 to 83dac0d Compare June 14, 2024 00:47
@Ncerzzk
Copy link
Contributor Author

Ncerzzk commented Jun 14, 2024

Or just this...

  _('upload_hardware').reset();

Thank you, this is a better way ^_^

@frank26080115
Copy link
Contributor

are you sure you want this? there might be people who have JSON files that only add PWM pins and want to leave the rest of the SPI alone

@pkendall64
Copy link
Collaborator

are you sure you want this? there might be people who have JSON files that only add PWM pins and want to leave the rest of the SPI alone

Yes we do want it this way. It is far more obvious that the uploaded file is a replacement not an addition.

@frank26080115
Copy link
Contributor

I do welcome the change, I have a collection of JSON files for my projects with a bunch of "" blank entries to blank out certain entries. But I realize that there's a possibility that the file can be used in an "append" fashion by other people. I hope this change is very prominently pointed out in the release notes.

@Ncerzzk Ncerzzk force-pushed the clear_hardware_before_upload branch from 83dac0d to cadcc57 Compare June 17, 2024 01:03
@pkendall64 pkendall64 merged commit 132ab0e into ExpressLRS:master Jun 17, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants