Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename flasher file used by configurator #142

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

pkendall64
Copy link
Contributor

Rename the binary_flash.py file to binary_configurator.py so builds from git using Configurator work correctly.

@pkendall64 pkendall64 added house keeping 🧹 Cleanup of code and house keeping V1.5 🍰 Version 1.5 labels Jul 20, 2024
@i-am-grub
Copy link
Contributor

It looks like the __init__.py and __main__.py will have to be updated to reflect the rename.

With the files changed, the configurator throws a generic build error without any indication of an issue in the logs.

ExpressLRSBuildLog_20240721020847255.txt

@i-am-grub
Copy link
Contributor

python files importing as expected - still having the same issue of the the generic build error. The firmware completes the build, but right before it attempts to flash, the build error is thrown.

@pkendall64
Copy link
Contributor Author

python files importing as expected - still having the same issue of the the generic build error. The firmware completes the build, but right before it attempts to flash, the build error is thrown.

I'm not having any error, it reports success. I selected the PR and Flash and it said success and popped up the finder window.

@i-am-grub
Copy link
Contributor

Figured out what is causing my issues. In the upload_espxx_xx functions, args.platform is used, but is never parsed in or set.

Adding args.platform = targets[vendor][hardware][target]['platform'] after the args are parsed in the main function got things going for me.

@pkendall64
Copy link
Contributor Author

Adding args.platform = targets[vendor][hardware][target]['platform'] after the args are parsed in the main function got things going for me.

Thanks for that.

@pkendall64 pkendall64 linked an issue Jul 22, 2024 that may be closed by this pull request
@MUSTARDTIGERFPV
Copy link
Contributor

seems legit 👍

@MUSTARDTIGERFPV MUSTARDTIGERFPV merged commit ad85322 into ExpressLRS:master Jul 25, 2024
35 checks passed
@pkendall64 pkendall64 deleted the fix-configurator branch July 25, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
house keeping 🧹 Cleanup of code and house keeping V1.5 🍰 Version 1.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to build official releases on windows using configurator
3 participants