-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MAVLink support to Backpack #141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inb4 this breaks the build on non TX backpack targets |
pkendall64
reviewed
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ifdef wrapping around the MAVLink specific code in devWIFI
>250Hz would cause an overflow at boot, and the overflow logic was backwards, not flushing the buffer or anything, just looping.
JyeSmith
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be easy as pie to use - Backpack autodetects when it sees MAVLink heartbeats and starts a WiFi network, and runs the "standard" UDP ports so Mission Planner should auto connect. Additionally, with ExpressLRS/ExpressLRS#2867, the TX now requests backpack mode changes as soon as link mode is set.
Open questions:
Does it work on STA mode? No reason why not, but haven't testedYes.More counters / status?How do we get Backpack out of MAVLink mode? Could simultaneously parse MSP and look for an exit command, or just say "nah reboot"Allow Backpack in MAVLink mode to come back to Normal mode automatically ExpressLRS#2867