Feat: Call useOnyx selector for entire collection #585

kacper-mikolajczak · 2024-09-30T10:55:10Z

Details

This PR makes useOnyx call its selector once for entire collection object instead of calling selector per item.

❗ As withOnyx is deprecated the change to its selector functionality was not implemented. In order to achieve this, separation between withOnyx and useOnyx selectors were introduced.

Implementation steps:

Modify tests to work with new functionality
Refactor typings to match new functionality
Fix implementation to make both test runner and type checker happy :)

Related Issues

Expensify/App#49644

Automated Tests

Manual Tests

Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

mjasikowski · 2024-09-30T11:17:00Z

@kacper-mikolajczak are these changes breaking for App or can this be pulled without a parallel App PR?

kacper-mikolajczak · 2024-09-30T11:31:37Z

Hi @mjasikowski!

Yes, this PR will lead to breaking changes to useOnyx selector.

Here is a PR that is going to contain all the necessary adjustments: Expensify/App#49918

I am going to add a few clean-up commits to this PR and will let you know when it is ready for review, if you don't mind.

mjasikowski · 2024-09-30T12:04:01Z

@kacper-mikolajczak thanks and no worries - I'd appreciate if you'd convert it to a Draft PR before it's until though.

kacper-mikolajczak · 2024-09-30T14:56:23Z

@mjasikowski PR is ready for review! We can also improve typings of useOnyx but it is outside the scope of this PR (I will try to work on it in the meantime)

lib/useOnyx.ts

fabioh8010 · 2024-10-01T09:58:42Z

Hi @kacper-mikolajczak could take a look at this diff? I basically fixed the TS typings and unified getCachedValue and getSelectedValue so we have the implementation the equal as possible to tryGetCachedValue.

diff --git a/lib/useOnyx.ts b/lib/useOnyx.ts
index 78fb050..24ea12d 100644
--- a/lib/useOnyx.ts
+++ b/lib/useOnyx.ts
@@ -1,11 +1,10 @@
 import {deepEqual, shallowEqual} from 'fast-equals';
 import {useCallback, useEffect, useRef, useSyncExternalStore} from 'react';
-import type {IsEqual} from 'type-fest';
 import OnyxCache from './OnyxCache';
 import type {Connection} from './OnyxConnectionManager';
 import connectionManager from './OnyxConnectionManager';
 import OnyxUtils from './OnyxUtils';
-import type {CollectionKeyBase, OnyxCollection, OnyxEntry, OnyxKey, OnyxValue} from './types';
+import type {CollectionKeyBase, KeyValueMapping, OnyxCollection, OnyxKey, OnyxValue} from './types';
 import useLiveRef from './useLiveRef';
 import usePrevious from './usePrevious';
 
@@ -47,67 +46,59 @@ type UseOnyxOptions<TKey extends OnyxKey, TReturnValue> = BaseUseOnyxOptions & U
 
 type FetchStatus = 'loading' | 'loaded';
 
-type SelectedValue<TKey, TValue> = TKey extends CollectionKeyBase ? OnyxCollection<TValue> : OnyxEntry<TValue>;
-
-type CachedValue<TKey extends OnyxKey, TValue> = IsEqual<TValue, OnyxValue<TKey>> extends true ? TValue : SelectedValue<TKey, TValue>;
+type CachedValue<TValue> = TValue;
 
 type ResultMetadata = {
     status: FetchStatus;
 };
 
-type UseOnyxResult<TKey extends OnyxKey, TValue> = [CachedValue<TKey, TValue>, ResultMetadata];
+type UseOnyxResult<TValue> = [CachedValue<TValue>, ResultMetadata];
 
-type UseOnyxSelector<TKey extends OnyxKey, SelectorValue> = (data?: OnyxValue<TKey>) => SelectorValue;
+type UseOnyxSelector<TKey extends OnyxKey, TReturnType> = (data: OnyxValue<TKey>) => TReturnType;
 
 /**
  * Gets the cached value from the Onyx cache. If the key is a collection key, it will return all the values in the collection.
  * It is a fork of `tryGetCachedValue` from `OnyxUtils` caused by different selector logic in `useOnyx`. It should be unified in the future, when `withOnyx` is removed.
  */
-function getCachedValue<TKey extends OnyxKey>(key: TKey): OnyxValue<TKey> | undefined {
-    if (!OnyxUtils.isCollectionKey(key)) {
-        return OnyxCache.get(key) as OnyxValue<TKey> | undefined;
-    }
-
-    const allCacheKeys = OnyxCache.getAllKeys();
+function getCachedValue<TKey extends OnyxKey, TValue>(key: TKey, selector?: UseOnyxSelector<TKey, TValue>): CachedValue<TValue> | undefined {
+    let val = OnyxCache.get(key);
 
-    // It is possible we haven't loaded all keys yet so we do not know if the
-    // collection actually exists.
-    if (allCacheKeys.size === 0) {
-        return;
-    }
+    if (OnyxUtils.isCollectionKey(key)) {
+        const allCacheKeys = OnyxCache.getAllKeys();
 
-    const values: Record<string, unknown> = {};
-    allCacheKeys.forEach((cacheKey) => {
-        if (!cacheKey.startsWith(key)) {
+        // It is possible we haven't loaded all keys yet so we do not know if the
+        // collection actually exists.
+        if (allCacheKeys.size === 0) {
             return;
         }
 
-        values[cacheKey] = OnyxCache.get(cacheKey);
-    });
-
-    return values as OnyxValue<TKey>;
-}
+        const values: OnyxCollection<KeyValueMapping[TKey]> = {};
+        allCacheKeys.forEach((cacheKey) => {
+            if (!cacheKey.startsWith(key)) {
+                return;
+            }
 
-/**
- * Gets the value from cache and maps it with selector.
- */
-function getSelectedValue<TKey extends OnyxKey, TValue = OnyxValue<TKey> | undefined>(key: TKey, selector?: UseOnyxSelector<TKey, TValue>) {
-    const value = getCachedValue(key);
+            values[cacheKey] = OnyxCache.get(cacheKey);
+        });
+        val = values;
+    }
 
-    const selectedValue = selector ? selector(value) : value;
+    if (selector) {
+        val = selector(val as OnyxValue<TKey>);
+    }
 
-    return selectedValue;
+    return val as CachedValue<TValue> | undefined;
 }
 
 function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(
     key: TKey,
     options?: BaseUseOnyxOptions & UseOnyxInitialValueOption<TReturnValue> & Required<UseOnyxSelectorOption<TKey, TReturnValue>>,
-): UseOnyxResult<TKey, TReturnValue>;
+): UseOnyxResult<TReturnValue>;
 function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(
     key: TKey,
     options?: BaseUseOnyxOptions & UseOnyxInitialValueOption<NoInfer<TReturnValue>>,
-): UseOnyxResult<TKey, TReturnValue>;
-function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(key: TKey, options?: UseOnyxOptions<TKey, TReturnValue>): UseOnyxResult<TKey, TReturnValue> {
+): UseOnyxResult<TReturnValue>;
+function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(key: TKey, options?: UseOnyxOptions<TKey, TReturnValue>): UseOnyxResult<TReturnValue> {
     const connectionRef = useRef<Connection | null>(null);
     const previousKey = usePrevious(key);
 
@@ -116,16 +107,16 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(key: TKey
 
     // Stores the previous cached value as it's necessary to compare with the new value in `getSnapshot()`.
     // We initialize it to `null` to simulate that we don't have any value from cache yet.
-    const previousValueRef = useRef<CachedValue<TKey, TReturnValue> | undefined | null>(null);
+    const previousValueRef = useRef<CachedValue<TReturnValue> | undefined | null>(null);
 
     // Stores the newest cached value in order to compare with the previous one and optimize `getSnapshot()` execution.
-    const newValueRef = useRef<CachedValue<TKey, TReturnValue> | undefined | null>(null);
+    const newValueRef = useRef<CachedValue<TReturnValue> | undefined | null>(null);
 
     // Stores the previously result returned by the hook, containing the data from cache and the fetch status.
     // We initialize it to `undefined` and `loading` fetch status to simulate the initial result when the hook is loading from the cache.
     // However, if `initWithStoredValues` is `false` we set the fetch status to `loaded` since we want to signal that data is ready.
-    const resultRef = useRef<UseOnyxResult<TKey, TReturnValue>>([
-        undefined as CachedValue<TKey, TReturnValue>,
+    const resultRef = useRef<UseOnyxResult<TReturnValue>>([
+        undefined as CachedValue<TReturnValue>,
         {
             status: options?.initWithStoredValues === false ? 'loaded' : 'loading',
         },
@@ -197,7 +188,7 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(key: TKey
             // If `newValueRef.current` is `null` or any other value it means that the cache does have a value for that key.
             // This difference between `undefined` and other values is crucial and it's used to address the following
             // conditions and use cases.
-            newValueRef.current = getSelectedValue(key, selectorRef.current) as CachedValue<TKey, TReturnValue>;
+            newValueRef.current = getCachedValue(key, selectorRef.current) as CachedValue<TReturnValue>;
 
             // We set this flag to `false` again since we don't want to get the newest cached value every time `getSnapshot()` is executed,
             // and only when `Onyx.connect()` callback is fired.
@@ -220,7 +211,7 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(key: TKey
         // If data is not present in cache and `initialValue` is set during the first connection,
         // we set the new value to `initialValue` and fetch status to `loaded` since we already have some data to return to the consumer.
         if (isFirstConnectionRef.current && !hasCacheForKey && options?.initialValue !== undefined) {
-            newValueRef.current = (options?.initialValue ?? undefined) as CachedValue<TKey, TReturnValue>;
+            newValueRef.current = (options?.initialValue ?? undefined) as CachedValue<TReturnValue>;
             newFetchStatus = 'loaded';
         }
 
@@ -242,7 +233,7 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(key: TKey
             previousValueRef.current = newValueRef.current;
 
             // If the new value is `null` we default it to `undefined` to ensure the consumer gets a consistent result from the hook.
-            resultRef.current = [previousValueRef.current as CachedValue<TKey, TReturnValue>, {status: newFetchStatus ?? 'loaded'}];
+            resultRef.current = [previousValueRef.current as CachedValue<TReturnValue>, {status: newFetchStatus ?? 'loaded'}];
         }
 
         return resultRef.current;
@@ -285,7 +276,7 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(key: TKey
         checkEvictableKey();
     }, [checkEvictableKey]);
 
-    const result = useSyncExternalStore<UseOnyxResult<TKey, TReturnValue>>(subscribe, getSnapshot);
+    const result = useSyncExternalStore<UseOnyxResult<TReturnValue>>(subscribe, getSnapshot);
 
     return result;
 }

kacper-mikolajczak · 2024-10-01T11:02:41Z

Nice @fabioh8010! I feel like we have similar idea in mind - please take a look at changes made here a16d45f and tell me if that works for you!

In the meantime I will try to merge your suggestions as well ❤️

lib/useOnyx.ts

mjasikowski

Looks good for my very limited knowledge, but I'd recommend to defer to @fabioh8010 and @mountiny for proper reviews.

mountiny · 2024-10-01T12:51:59Z

@hungvu193 added for review and testing

fabioh8010

some minor comments, but it's looking great!

lib/useOnyx.ts

kacper-mikolajczak · 2024-10-02T09:55:18Z

As of what @fabioh8010 shared internally, the useOnyx cannot return null so the selector will also override null values with undefined to remain consistent:

return selectedValue ?? undefined;

kacper-mikolajczak · 2024-10-02T11:11:36Z

Thanks for all the suggestions @fabioh8010!

All the changes should be applied - let me know what you think 🙏

fabioh8010

Left one question, besides LGTM 🚀 Thanks for the work and patience here!!

lib/useOnyx.ts

kacper-mikolajczak · 2024-10-02T13:41:05Z

Wild idea as another potential improvement: What if we apply selector at the end of useOnyx pipeline and rely internally on actual Onyx cache data as source of truth?

It should simplify the typings and also enable possibility to return null values from useOnyx selectors as well. Also it should yield positive performance result as we won't do the deepEquality check whenever selector is applied - only rely on shallow checks for state (the requirement is cache state internally has stable reference, otherwise this idea is not feasible)

Here's a diff:

diff --git a/lib/useOnyx.ts b/lib/useOnyx.ts
index e294fe9..fa8e4d4 100644
--- a/lib/useOnyx.ts
+++ b/lib/useOnyx.ts
@@ -1 +1 @@
-import {deepEqual, shallowEqual} from 'fast-equals';
+import {shallowEqual} from 'fast-equals';
@@ -123,2 +123,2 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(key: TKey
-    const resultRef = useRef<UseOnyxResult<TReturnValue>>([
-        undefined,
+    const resultRef = useRef<[TReturnValue | undefined, ResultMetadata]>([
+        selectorRef.current?.(undefined),
@@ -196 +196 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(key: TKey
-            newValueRef.current = getCachedValue(key, selectorRef.current);
+            newValueRef.current = getCachedValue(key);
@@ -226,6 +226 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(key: TKey
-        let areValuesEqual: boolean;
-        if (selectorRef.current) {
-            areValuesEqual = deepEqual(previousValueRef.current ?? undefined, newValueRef.current);
-        } else {
-            areValuesEqual = shallowEqual(previousValueRef.current ?? undefined, newValueRef.current);
-        }
+        const areValuesEqual = shallowEqual(previousValueRef.current ?? undefined, newValueRef.current);
@@ -241 +236 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(key: TKey
-            resultRef.current = [previousValueRef.current ?? undefined, {status: newFetchStatus ?? 'loaded'}];
+            resultRef.current = [selectorRef.current(previousValueRef.current ?? undefined), {status: newFetchStatus ?? 'loaded'}];

fabioh8010 · 2024-10-02T15:12:03Z

Wild idea as another potential improvement: What if we apply selector at the end of useOnyx pipeline and rely internally on actual Onyx cache data as source of truth?

It should simplify the typings and also enable possibility to return null values from useOnyx selectors as well. Also it should yield positive performance result as we won't do the deepEquality check whenever selector is applied - only rely on shallow checks for state (the requirement is cache state internally has stable reference, otherwise this idea is not feasible)

Here's a diff:

diff --git a/lib/useOnyx.ts b/lib/useOnyx.ts
index e294fe9..fa8e4d4 100644
--- a/lib/useOnyx.ts
+++ b/lib/useOnyx.ts
@@ -1 +1 @@
-import {deepEqual, shallowEqual} from 'fast-equals';
+import {shallowEqual} from 'fast-equals';
@@ -123,2 +123,2 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(key: TKey
-    const resultRef = useRef<UseOnyxResult<TReturnValue>>([
-        undefined,
+    const resultRef = useRef<[TReturnValue | undefined, ResultMetadata]>([
+        selectorRef.current?.(undefined),
@@ -196 +196 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(key: TKey
-            newValueRef.current = getCachedValue(key, selectorRef.current);
+            newValueRef.current = getCachedValue(key);
@@ -226,6 +226 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(key: TKey
-        let areValuesEqual: boolean;
-        if (selectorRef.current) {
-            areValuesEqual = deepEqual(previousValueRef.current ?? undefined, newValueRef.current);
-        } else {
-            areValuesEqual = shallowEqual(previousValueRef.current ?? undefined, newValueRef.current);
-        }
+        const areValuesEqual = shallowEqual(previousValueRef.current ?? undefined, newValueRef.current);
@@ -241 +236 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(key: TKey
-            resultRef.current = [previousValueRef.current ?? undefined, {status: newFetchStatus ?? 'loaded'}];
+            resultRef.current = [selectorRef.current(previousValueRef.current ?? undefined), {status: newFetchStatus ?? 'loaded'}];

@kacper-mikolajczak I think this idea makes very much sense! I’m just worried about how we currently use selector inside useOnyx — we use a “live ref” and I think with this approach we may have stale renders, so we need to test this properly.

But do you think we could work on this separately in another Proposal / Issue / PR? So we keep the scope of the current PR small and allow a quicker merge, less chance of regressions, and more time to think about the solution.

WDYT?

hungvu193 · 2024-10-02T15:42:58Z

The last line here confuses me:

- resultRef.current = [previousValueRef.current ?? undefined, {status: newFetchStatus ?? 'loaded'}]
+ resultRef.current = [selectorRef.current(previousValueRef.current ?? undefined), {status: newFetchStatus ?? 'loaded'}];

According to the current code, I assume selectorRef.current can be undefined right?

        if (selectorRef.current) {
            areValuesEqual = deepEqual(previousValueRef.current ?? undefined, newValueRef.current);
        } else {
            areValuesEqual = shallowEqual(previousValueRef.current ?? undefined, newValueRef.current);
        }

So I'd agree with @fabioh8010, we should work on it in a separate issue.

hungvu193

LGTM. Just one NAB comment

lib/useOnyx.ts

mountiny · 2024-10-02T16:07:41Z

@hungvu193 did you test the changes applied to App? Can you please do so now before we merge such change? Thanks!

hungvu193 · 2024-10-02T16:50:41Z

@hungvu193 did you test the changes applied to App? Can you please do so now before we merge such change? Thanks!

Yes. So far so good. I can verify that the selector is called once for the entire collection. I haven't found any issues so far, but let me test it carefully to make sure it won't affect any existing flows.

Screen.Recording.2024-10-02.at.23.45.30.mov

hungvu193 · 2024-10-03T02:07:37Z

All good @mountiny

kacper-mikolajczak · 2024-10-03T09:07:54Z

I’m just worried about how we currently use selector inside useOnyx — we use a “live ref” and I think with this approach we may have stale renders

I will give it a go and get back to you guys with separate proposal if change turns out to be positive 👍

Let's close this PR as soon as we can!

mountiny

Dont want to delay this too much but also going to ask Margelo to review

mountiny · 2024-10-03T23:42:06Z

https://expensify.slack.com/archives/C035J5C9FAP/p1727998618219179

hannojg

LGTM!

hannojg · 2024-10-04T07:03:03Z

lib/useOnyx.ts

+    const value = tryGetCachedValue(key) as OnyxValue<TKey>;
+
+    const selectedValue = selector ? selector(value) : (value as TValue);



just wondering for the future if the onyx cache could also have a cache of key + selector function, so that when the selector function remains the same, the data remains the same we don't have to rerun the selector (as selectors could be expensive to run) [maybe this should be opt in though]

Thanks for review Hanno!

What came up as a next improvement while working on this issue was the idea to separate selector from useOnyx internals entirely so it won't interfere with Onyx cache and only transform the cached data at the end of the pipeline.

It should have many benefits, but I am still working on the PoC whether it is feasible for us to implement 🤞

mountiny · 2024-10-04T10:56:41Z

Going to merge this one now

github-actions · 2024-10-04T10:57:24Z

🚀Published to npm in v2.0.73

kacper-mikolajczak added 3 commits September 27, 2024 11:56

update selector collection test to match new functionality

174684a

useOnyx collection selector changes

5a53c32

useOnyx selector changes part2

fbb4a8c

kacper-mikolajczak requested a review from a team as a code owner September 30, 2024 10:55

melvin-bot bot requested review from mjasikowski and removed request for a team September 30, 2024 10:55

Merge branch 'main' into feat/selector-collection-state

5b94e00

kacper-mikolajczak mentioned this pull request Sep 30, 2024

[NoQA] Adjust useOnyx selector for collections Expensify/App#49918

Merged

50 tasks

kacper-mikolajczak added 2 commits September 30, 2024 13:26

cleanup

397b4dd

cleanup part 2

a41bd1b

kacper-mikolajczak marked this pull request as draft September 30, 2024 13:20

kacper-mikolajczak added 3 commits September 30, 2024 15:43

cleanup part 3

68c2702

cleanup part 4

b74380b

scary exclamation mark

ee1d28d

kacper-mikolajczak marked this pull request as ready for review September 30, 2024 14:55

fabioh8010 reviewed Oct 1, 2024

View reviewed changes

lib/useOnyx.ts Show resolved Hide resolved

lib/useOnyx.ts Outdated Show resolved Hide resolved

lib/useOnyx.ts Outdated Show resolved Hide resolved

lib/useOnyx.ts Outdated Show resolved Hide resolved

lib/useOnyx.ts Outdated Show resolved Hide resolved

add comments for helpers

24a9e8b

kacper-mikolajczak requested a review from fabioh8010 October 1, 2024 08:28

mountiny requested review from mountiny and removed request for fabioh8010 October 1, 2024 09:05

mountiny assigned kacper-mikolajczak Oct 1, 2024

fix typings

a16d45f

fix null typo

7c65dd0

fabioh8010 reviewed Oct 1, 2024

View reviewed changes

lib/useOnyx.ts Show resolved Hide resolved

lib/useOnyx.ts Outdated Show resolved Hide resolved

lib/useOnyx.ts Outdated Show resolved Hide resolved

revive overloads

18a84ba

mjasikowski previously approved these changes Oct 1, 2024

View reviewed changes

mountiny requested a review from hungvu193 October 1, 2024 12:50

fabioh8010 reviewed Oct 1, 2024

View reviewed changes

batched types fixes

4629b78

kacper-mikolajczak dismissed mjasikowski’s stale review via 4629b78 October 2, 2024 10:58

kacper-mikolajczak requested a review from fabioh8010 October 2, 2024 11:01

fix copy&paste accidents

81127bf

kacper-mikolajczak force-pushed the feat/selector-collection-state branch from a76b8d8 to 81127bf Compare October 2, 2024 11:13

fabioh8010 approved these changes Oct 2, 2024

View reviewed changes

lib/useOnyx.ts Show resolved Hide resolved

hungvu193 approved these changes Oct 2, 2024

View reviewed changes

lib/useOnyx.ts Show resolved Hide resolved

update comment

5a82d80

mountiny approved these changes Oct 3, 2024

View reviewed changes

hannojg approved these changes Oct 4, 2024

View reviewed changes

mountiny merged commit 40cc9cf into Expensify:main Oct 4, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Call useOnyx selector for entire collection #585

Feat: Call useOnyx selector for entire collection #585

kacper-mikolajczak commented Sep 30, 2024 •

edited

Loading

mjasikowski commented Sep 30, 2024 •

edited

Loading

kacper-mikolajczak commented Sep 30, 2024 •

edited

Loading

mjasikowski commented Sep 30, 2024 •

edited

Loading

kacper-mikolajczak commented Sep 30, 2024

fabioh8010 commented Oct 1, 2024

kacper-mikolajczak commented Oct 1, 2024 •

edited

Loading

mjasikowski left a comment

mountiny commented Oct 1, 2024

fabioh8010 left a comment

kacper-mikolajczak commented Oct 2, 2024

kacper-mikolajczak commented Oct 2, 2024

fabioh8010 left a comment

kacper-mikolajczak commented Oct 2, 2024

fabioh8010 commented Oct 2, 2024

hungvu193 commented Oct 2, 2024

hungvu193 left a comment

mountiny commented Oct 2, 2024

hungvu193 commented Oct 2, 2024

hungvu193 commented Oct 3, 2024

kacper-mikolajczak commented Oct 3, 2024

mountiny left a comment

mountiny commented Oct 3, 2024

hannojg left a comment

hannojg Oct 4, 2024 •

edited

Loading

kacper-mikolajczak Oct 4, 2024

mountiny commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

		const value = tryGetCachedValue(key) as OnyxValue<TKey>;

		const selectedValue = selector ? selector(value) : (value as TValue);

Feat: Call useOnyx selector for entire collection #585

Feat: Call useOnyx selector for entire collection #585

Conversation

kacper-mikolajczak commented Sep 30, 2024 • edited Loading

Details

Related Issues

Automated Tests

Manual Tests

Author Checklist

Screenshots/Videos

mjasikowski commented Sep 30, 2024 • edited Loading

kacper-mikolajczak commented Sep 30, 2024 • edited Loading

mjasikowski commented Sep 30, 2024 • edited Loading

kacper-mikolajczak commented Sep 30, 2024

fabioh8010 commented Oct 1, 2024

kacper-mikolajczak commented Oct 1, 2024 • edited Loading

mjasikowski left a comment

Choose a reason for hiding this comment

mountiny commented Oct 1, 2024

fabioh8010 left a comment

Choose a reason for hiding this comment

kacper-mikolajczak commented Oct 2, 2024

kacper-mikolajczak commented Oct 2, 2024

fabioh8010 left a comment

Choose a reason for hiding this comment

kacper-mikolajczak commented Oct 2, 2024

fabioh8010 commented Oct 2, 2024

hungvu193 commented Oct 2, 2024

hungvu193 left a comment

Choose a reason for hiding this comment

mountiny commented Oct 2, 2024

hungvu193 commented Oct 2, 2024

hungvu193 commented Oct 3, 2024

kacper-mikolajczak commented Oct 3, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Oct 3, 2024

hannojg left a comment

Choose a reason for hiding this comment

hannojg Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

kacper-mikolajczak Oct 4, 2024

Choose a reason for hiding this comment

mountiny commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

kacper-mikolajczak commented Sep 30, 2024 •

edited

Loading

mjasikowski commented Sep 30, 2024 •

edited

Loading

kacper-mikolajczak commented Sep 30, 2024 •

edited

Loading

mjasikowski commented Sep 30, 2024 •

edited

Loading

kacper-mikolajczak commented Oct 1, 2024 •

edited

Loading

hannojg Oct 4, 2024 •

edited

Loading