Skip to content

[No QA]: Cleanup old buildNextStep function and remove connect method #76297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+332 −550
Open

[No QA]: Cleanup old buildNextStep function and remove connect method #76297

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a84cfaf
Cleanup
DylanDylann Nov 28, 2025
b170e8f
prettier
DylanDylann Nov 28, 2025
32defa2
add dependency
DylanDylann Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/MoneyReportHeaderStatusBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React, {useMemo} from 'react';
import {View} from 'react-native';
import type {ValueOf} from 'type-fest';
import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails';
import useTheme from '@hooks/useTheme';
import useThemeStyles from '@hooks/useThemeStyles';
import {parseMessage} from '@libs/NextStepUtils';
Expand All @@ -9,7 +10,7 @@
import type ReportNextStepDeprecated from '@src/types/onyx/ReportNextStepDeprecated';
import type IconAsset from '@src/types/utils/IconAsset';
import Icon from './Icon';
import * as Expensicons from './Icon/Expensicons';

Check warning on line 13 in src/components/MoneyReportHeaderStatusBar.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

'./Icon/Expensicons' import is restricted from being used by a pattern. Direct imports from Icon/Expensicons are deprecated. Please use lazy loading hooks instead. Use `useMemoizedLazyExpensifyIcons` from @hooks/useLazyAsset. See docs/LAZY_ICONS_AND_ILLUSTRATIONS.md for details
import RenderHTML from './RenderHTML';

type MoneyReportHeaderStatusBarProps = {
Expand All @@ -28,10 +29,11 @@
function MoneyReportHeaderStatusBar({nextStep}: MoneyReportHeaderStatusBarProps) {
const styles = useThemeStyles();
const theme = useTheme();
const currentUserPersonalDetails = useCurrentUserPersonalDetails();
const messageContent = useMemo(() => {
const messageArray = nextStep?.message;
return parseMessage(messageArray);
return parseMessage(messageArray, currentUserPersonalDetails.login ?? '');
}, [nextStep?.message]);

Check warning on line 36 in src/components/MoneyReportHeaderStatusBar.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

React Hook useMemo has a missing dependency: 'currentUserPersonalDetails.login'. Either include it or remove the dependency array

return (
<View style={[styles.dFlex, styles.flexRow, styles.alignItemsCenter, styles.overflowHidden, styles.w100, styles.headerStatusBarContainer]}>
Expand Down
Loading
Loading