Skip to content

Fix: Replace FullScreenLoadingIndicator with ActivityIndicator in AddressSearch Component #76156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+5 −2
Open

Fix: Replace FullScreenLoadingIndicator with ActivityIndicator in AddressSearch Component #76156

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68888a2
Replace FullScreenLoadingIndicator with ActivityIndicator in AddressS…
PiyushChandra17 Nov 26, 2025
91307da
remove style from ActivityIndicator
PiyushChandra17 Nov 27, 2025
edc0175
Added CONST.ACTIVITY_INDICATOR_SIZE.LARGE && styles.h100
PiyushChandra17 Nov 28, 2025
55afba6
Merge branch 'Expensify:main' into fix/75535
PiyushChandra17 Nov 28, 2025
4654d20
added styles.mt7
PiyushChandra17 Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/AddressSearch/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import type {LayoutChangeEvent} from 'react-native';
import {GooglePlacesAutocomplete} from 'react-native-google-places-autocomplete';
import type {GooglePlaceData, GooglePlaceDetail} from 'react-native-google-places-autocomplete';
import ActivityIndicator from '@components/ActivityIndicator';
import FullScreenLoadingIndicator from '@components/FullscreenLoadingIndicator';
import LocationErrorMessage from '@components/LocationErrorMessage';
import ScrollView from '@components/ScrollView';
import Text from '@components/Text';
Expand Down Expand Up @@ -480,7 +479,7 @@ function AddressSearch({
</GooglePlacesAutocomplete>
</View>
</ScrollView>
{isFetchingCurrentLocation && <FullScreenLoadingIndicator />}
{isFetchingCurrentLocation && <ActivityIndicator size="large" />}
Copy link
Contributor

@Krishna2323 Krishna2323 Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use CONST.ACTIVITY_INDICATOR_SIZE.LARGE.

Copy link
Contributor Author

@PiyushChandra17 PiyushChandra17 Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krishna2323 exactly i was thinking the same, thanks

</>
);
}
Expand Down
Loading