Skip to content

Fix: Remove non-dismissable error message on the Expensify card page #75672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −7
Open

Fix: Remove non-dismissable error message on the Expensify card page #75672

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d62709d
Fix: Remove non-dismissable error message on the card page
ryntgh Nov 20, 2025
30c31de
Merge branch 'main' into issue/73134
ryntgh Nov 25, 2025
25c91df
Fix: Remove non-dismissable error message on the Expensify card page
ryntgh Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/pages/settings/Wallet/ExpensifyCardPage/ExpensifyCardVerifyAccountPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ import useLocalize from '@hooks/useLocalize';
import useOnyx from '@hooks/useOnyx';
import {revealVirtualCardDetails} from '@libs/actions/Card';
import {requestValidateCodeAction, resetValidateActionCodeSent} from '@libs/actions/User';
import {getMicroSecondOnyxErrorWithTranslationKey} from '@libs/ErrorUtils';
import Navigation from '@libs/Navigation/Navigation';
import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types';
import type {DomainCardNavigatorParamList, SettingsNavigatorParamList} from '@libs/Navigation/types';
import type {TranslationPaths} from '@src/languages/types';
import ONYXKEYS from '@src/ONYXKEYS';
import ROUTES from '@src/ROUTES';
import SCREENS from '@src/SCREENS';
Expand Down Expand Up @@ -52,13 +54,8 @@ function ExpensifyCardVerifyAccountPage({route}: ExpensifyCardVerifyAccountPageP
}));
navigateBack();
})
.catch((error: string) => {
// Displaying magic code errors is handled in the modal, no need to set it on the card
setCardsDetailsErrors((prevState) => ({
...prevState,
[cardID]: error,
}));
navigateBack();
Copy link
Contributor

@bernhardoj bernhardoj Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that navigateBack was added from #68749. @MonilBhavsar if the user inputs a wrong magic code, they will be navigated back.

web.mp4

This is the previous behavior. The user stays on the magic code page.

web.mp4

In this PR, we want to keep the user on the magic code page and show any errors on the magic code page. Does that fine with you?

Copy link
Contributor

@MonilBhavsar MonilBhavsar Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, we implemented the fix because there was no error to display on the magic code page cc @joekaufmanexpensify

Copy link
Contributor

@bernhardoj bernhardoj Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryntgh can you test #68749 on this PR and see if the error shown correctly?

Copy link
Contributor Author

@ryntgh ryntgh Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernhardoj I couldn't really test this since I can't connect with an EU/UK bank account. But I noticed that the latest change in the PR was to automatically redirect to ROUTES.SETTINGS_WALLET_CARD_MISSING_DETAILS for EU/UK cards (I hardcoded this to US)

MacOS-Chrome.mp4

Since I can't use an EU/UK bank account, I couldn't confirm whether the missing personal details error message is shown correctly

Copy link
Contributor

@bernhardoj bernhardoj Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonilBhavsar do you know how can I add a EU/UK bank account?

Copy link
Contributor

@bernhardoj bernhardoj Nov 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryntgh Btw, can you merge with main, please?

Copy link
Contributor Author

@ryntgh ryntgh Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, merged with the latest main!

Copy link
Contributor

@bernhardoj bernhardoj Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryntgh I get this error when trying to simulate the missing details error.

image

You can try rejecting the promise in revealVirtualCardDetails.
reject('cardPage.missingPrivateDetails');

Copy link
Contributor

@bernhardoj bernhardoj Nov 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryntgh after thinking more about it, I think it's better to keep the previous logic if the error is 'cardPage.missingPrivateDetails' because it's not a magic code error. What do you think?

Copy link
Contributor Author

@ryntgh ryntgh Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernhardoj Yeah, I agree. Keeping the previous logic for that case seems like the better approach

.catch((error: TranslationPaths) => {
setValidateError(getMicroSecondOnyxErrorWithTranslationKey(error));
})
.finally(() => {
setIsCardDetailsLoading((prevState: Record<number, boolean>) => ({...prevState, [cardID]: false}));
Expand Down
Loading