fix: update the report primary action for when an export fails

[nkdengineer]

Explanation of Change

Fixed Issues

$ #70101
PROPOSAL: #70101 (comment)

Tests

1. Create a new workspace with connect accounting
2. Submit an expense
3. Approve this expense
4. Try to export as accounting fails
5. Verify that: Primary action show the Export button instead of Pay button
6. Verify that: next step message should show Waiting for [preferredExporter] to export this report

• Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android.mov

iOS: Native

i.mov

iOS: mWeb Safari

im.mov

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[nkdengineer]

backend is on staging

i'll add the screenshots today

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MoneyReportHeader.tsx	0.17% <ø> (ø)
src/libs/ReportPrimaryActionUtils.ts	89.32% <100.00%> (+0.15%)	⬆️
src/libs/ReportSecondaryActionUtils.ts	91.03% <100.00%> (+0.07%)	⬆️
... and 20 files with indirect coverage changes

[nkdengineer]

@dominictb i added the screenshots but the next steps message is still updated as expected. Can you please check on your end?

[dominictb]

Yeah the next step message is not working for me.

It's Waiting for [someone] to pay expenses. for manual export action:

Waiting for [someone] to pay expenses. Report is queued to auto-sync with QuickBooks Online shortly. for auto export:

(screenshot from @nkdengineer)

cc @dangrous Can you check if it's working on your side?

[dangrous]

Oh weird, it was working before? Here are the test steps I was using (and QA used) on the backend change -

• Create a workspace with a connection to NetSuite or other external platform
• Create, submit, and approve a report
• Wait for the report to export successfully to NetSuite/the connection
• Ensure the next step is waiting for [admin] to pay expenses
• Try again but change the configuration of the report / connection as needed to ensure a failed export (mismatched currencies usually works)
• Wait for the report failure message
• Ensure the next step is waiting for [preferredExporter] to export this report.

Does that differ in a relevant way from the testing here?

[dominictb]

@dangrous Here's my test steps:

• Create a workspace with a connection to NetSuite or other external platform
• Create, submit, and approve a report
• Either:
  • Wait for the report to export automatically; or
  • Manually trigger export from secondary actions menu
• The export fails but next step message is still Waiting for [someone] to pay expenses.

So it's different from your test steps because it failed right from the first place. I expect that whenever export failed, we should show the Waiting for export next step, correct?

[dangrous]

oh okay i think i see what's happening here - so if you refresh the page with your report, does it hten show the export message?

We don't send an Onyx update with the new next step when the export fails, but if you leave and come back it should be the updated message. That's what I'm seeing, at least

[dominictb]

if you leave and come back it should be the updated message

@dangrous It's not working either:

Screen.Recording.2025-10-29.at.19.48.38.mov

[dangrous]

if you leave and come back it should be the updated message

@dangrous It's not working either:

Screen.Recording.2025-10-29.at.19.48.38.mov

That's odd! on staging it's working for me...

[nkdengineer]

@dominictb Updated.

[dominictb]

@dangrous I noticed that it only works when the report is auto sync. If I manually export before auto sync, the message won't show.

[dangrous]

oh interesting, I must have missed a condition somewhere. Let me try to repro and get an update out there if I can figure it out!

[dangrous]

Hrm, even when I manually click the export option, before the autosync goes through, I still get the correct next step on dev. And using the "mark as exported" option would by default never fail.

can you try again, and/or write down the exact steps to replicate the behavior where it's still showing the old message? Maybe I'm missing something.

[dominictb]

@dangrous It might be due to accounting configuration. Mine is to export after approval not after payment (export.accoutingMethod === 'ACCRUAL').

1. Create, submit and approve an expense
2. It's auto exported to Sage and fails
3. Next step message is Waiting for you to pay expenses. Report is queued to auto-sync with Intacct shortly.
4. After that, even I manually export, the next step message is still same as above (after switching to another report and back)

Can you retry?

[dangrous]

Hrm, I'm not able to get Sage working locally, annoyingly. However, separately - I learned about another way we can figure out if an export is failed, using the rNVP exportFailedTime - so I'm going to adjust the backend to look for that and maybe we can see if that fixes it.

EDIT: I got it to connect locally, testing now. The answer may still be what I said, though.

EDIT EDIT: Yep, I see the behavior you're seeing now. Will test if my new theory fixes it!

[dangrous]

Okay so trying to figure out the expected behavior. With my new backend change, and your set up (on accrual), it successfully now says "waiting for you to export" after the failure. But then when I mark it as manually exported, it goes back to "Waiting for you to pay expenses. Report is queued to auto-sync with Intacct shortly." Is that correct? I feel like maybe it is, since it's unrelated logic that makes that "queued" part show up, but I'm unsure. Do you know or should we ask in Slack?

[dominictb]

Waiting for you to pay expenses. Report is queued to auto-sync with Intacct shortly.

I think it's correct based on this:

Exported and reimbursed reports will sync payment status between Expensify and QuickBooks Online during the next auto-sync.

That means it'll sync the reimbursement status to accounting during the auto-sync. But you can ask for confirmation from the team to be extra sure. Feel free to deploy the BE changes and I'll retest.

[heyjennahay]

No concerns with the product change

[dominictb]

@dangrous How's the BE fix/discussion?

[dangrous]

It should be set! Feel free to test again and if we're still seeing issues let me know

[dominictb]

Thanks! The next step message is correct now:

[dominictb]

However, after successfully exporting the report, report.isExportedToIntegration is still false:

The report did get exported to Intacct:

@dangrous Can you help us to quick check why? I don't see this property being handled in the FE, read only.

[dominictb]

@dangrous Can you share the progress of checking ☝️ bug?