-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No Q/A] Adding updated commercial feed HelpDot images (take 2) #56179
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
@OfstadC removing your review as this is just adding images. |
@rojiphil please approve to go to internal reviewer. |
A preview of your ExpensifyHelp changes have been deployed to https://987e5a25.helpdot.pages.dev ⚡️ |
This comment was marked as off-topic.
This comment was marked as off-topic.
@tgolen @Christinadobrzyn One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you need a reviewer on this but they look great! Approved!
I approved the review of these images - just so that's not a blocker! |
Explanation of Change
Adding updated commercial feed helpdot images. Originally done in #55987 , but the merged PR got deleted as part of a cleanup to remove unrelated bad commits from the repo.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/439387
QA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videosundefined