-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Expensify Travel terms & conditions copy #55806
base: main
Are you sure you want to change the base?
Conversation
…upData being empty
…efault-number-id-usage # Conflicts: # src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx # src/pages/iou/request/step/IOURequestStepParticipants.tsx
…/50360-wrong-default-number-id-usage Fix wrong default number id usages
[No QA] Fix createNewVersion again
[No QA] fix: default chat report id
[No QA] Point Mobile-Expensify back at main
[No QA] Update SearchPolicy
…ion-policy Translate cancellation policy for hotel details page, recapitalize hotel names
Add files via upload
I had to do some messing around here so I'm going to use pullerbear to assign another engineer |
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
The merge-base changed after approval.
Hey James, so this PR got super screwed up by a fire we had last week. I'm going to re-make the PR on a new branch since the changes are small |
Sounds good, thanks! |
Making copy more concise
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop