Simplify single line TextInput styling to allow for different heights #55343

Kicu · 2025-01-16T09:18:03Z

This PR is needed for 2 other PRs that are being worked on.

Explanation of Change

Previously we almost never rendered TextInput that was both:

single line (multiline=false)
markdown enabled (isMarkdownEnabled=true)

We mostly have either multiline RNLiveMarkdown components or simple single line text components.
Very soon we will start to use a single-line RNLiveMarkdown component in Search (check this PR: #54403) - and for this I needed to modify some Input styling.

The changes in this PR are to solve 2 separate but related things:

currently a single-line text input will have its height hardcoded to 52px, but in here there was a need to change the height: [HOLD for payment 2025-02-07] [HOLD for payment 2025-02-04] [$250] Update Search page to always show search input and type tabs at the top #52317 (comment)
In Search we want to introduce using LiveMarkdown instead of standard TextInput, and there are problems with aligning text (see this comment: [Search v2.5] [Autocomplete] Highlight autocomplete key and selected value #50949 (comment)) - this PR fixes it by removing the flex styles from View parent of input, which does not break any other use cases
the height + lineHeight hack had to say for iOS unfortunately

Fixed Issues

$ #50949
$ #52317
PROPOSAL:

Tests

verify that standard single line inputs look good:
- create Expense > choose someone > edit Merchant field
- Workspaces > Tags (or Taxes) > edit tag or tax name
verify that multiline live markdown looks good:
- create Expense > choose someone > edit Description field
- any and all usages of Composer (main input in chat, in threads)

NOTE: single line live markdown will be tested once we add it in another PR

Offline tests

QA Steps

verify that standard single line inputs look good:
- create Expense > choose someone > edit Merchant field
- Workspaces > Tags (or Taxes) > edit tag or tax name
verify that multiline live markdown looks good:
- create Expense > choose someone > edit Description field
- any and all usages of Composer (main input in chat, in threads)
test that adding and removing emojis looks good in these ☝️ inputs

PR Author Checklist

Screenshots/Videos

Android: Native

rec-andr-lms.mp4

Android: mWeb Chrome

rec-andr-mweb-lms.mp4

iOS: Native

rec-ios-lms.mov

iOS: mWeb Safari

rec-ios-mweb-lms.mp4

MacOS: Chrome / Safari

rec-web-lms.mp4

MacOS: Desktop

melvin-bot · 2025-01-16T09:18:08Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

Kicu · 2025-01-16T15:12:53Z

src/styles/index.ts

@@ -1247,8 +1247,6 @@ const styles = (theme: ThemeColors) =>
        },

        textInputAndIconContainer: {


this style is only used inside TextInput and the changes were tested as part of this task - it does not affect anything else

melvin-bot · 2025-01-17T09:50:56Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Kicu · 2025-01-17T09:51:28Z

CC @luacmartins for visibility, we need this for live markdown highlighting in Search.

luacmartins

LGTM. @rayane-djouah all yours

rayane-d · 2025-01-20T10:37:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-23.at.3.37.16.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-01-23.at.3.34.11.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-23.at.15.29.03.mp4

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-23.at.15.30.09.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-23.at.15.36.47.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-01-23.at.3.41.52.PM.mov

MacOS: Desktop

Screen.Recording.2025-01-23.at.3.40.31.PM.mov

rayane-d

The code looks good. I will thoroughly test the changes tomorrow to make sure nothing is broken.

luacmartins · 2025-01-21T15:40:52Z

Thanks @rayane-djouah

rayane-d · 2025-01-21T21:24:14Z

BUG: In the iOS native app, the custom message text input for new member invitations is shifted to the top.

Before	After

Before	After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-21.at.22.05.06.mp4	Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-21.at.22.13.11.mp4

cc @Kicu

Kicu · 2025-01-22T06:35:53Z

Looking 👀

Kicu · 2025-01-22T09:51:17Z

Fixed by returning 1 style that I removed, verified that it works.

Screen.Recording.2025-01-22.at.10.49.20.mov

luacmartins · 2025-01-22T14:24:05Z

@rayane-djouah let's prioritize reviewing this one when you're online since it blocks other Search v2.5 work.

rayane-d

LGTM and tests well

OSBotify · 2025-01-23T14:55:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-23T18:28:26Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-28T01:51:50Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Kicu force-pushed the kicu/live-markdown-input-styling branch from 122de64 to 0131ea7 Compare January 16, 2025 15:00

Kicu added 2 commits January 16, 2025 16:05

Simplify single line TextInput styling to allow for different heights

ea55266

Fix new lint rules

04c80f6

Kicu force-pushed the kicu/live-markdown-input-styling branch from 0131ea7 to 04c80f6 Compare January 16, 2025 15:09

Kicu commented Jan 16, 2025

View reviewed changes

Kicu marked this pull request as ready for review January 17, 2025 09:50

Kicu requested review from a team as code owners January 17, 2025 09:50

melvin-bot bot requested review from rayane-d and removed request for a team January 17, 2025 09:50

luacmartins self-requested a review January 17, 2025 13:53

luacmartins previously approved these changes Jan 17, 2025

View reviewed changes

rayane-d reviewed Jan 21, 2025

View reviewed changes

apply height style only to multiline TextInput

27e039d

Kicu dismissed luacmartins’s stale review via 27e039d January 22, 2025 09:50

luacmartins requested review from rayane-d and luacmartins January 22, 2025 13:44

Kicu mentioned this pull request Jan 22, 2025

[Search v2.5] [Autocomplete] Highlight autocomplete key and selected value #50949

Open

rayane-d approved these changes Jan 23, 2025

View reviewed changes

luacmartins approved these changes Jan 23, 2025

View reviewed changes

luacmartins merged commit ee3441b into Expensify:main Jan 23, 2025
17 of 18 checks passed

github-actions bot mentioned this pull request Jan 23, 2025

Deploy Checklist: New Expensify 2025-01-23 #55657

Closed

rayane-d mentioned this pull request Jan 23, 2025

[HOLD for payment 2025-02-07] [HOLD for payment 2025-02-04] [$250] Update Search page to always show search input and type tabs at the top #52317

Open

This was referenced Jan 23, 2025

[HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] Split - Individual split amount field is not aligned correctly #55662

Closed

Revert "Simplify single line TextInput styling to allow for different heights" #55668

Closed

Kicu mentioned this pull request Jan 24, 2025

[CP Staging] Fix wrong align of TextInput when displaying currency/icon #55711

Merged

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify single line TextInput styling to allow for different heights #55343

Simplify single line TextInput styling to allow for different heights #55343

Kicu commented Jan 16, 2025 •

edited

Loading

melvin-bot bot commented Jan 16, 2025

Kicu Jan 16, 2025

melvin-bot bot commented Jan 17, 2025

Kicu commented Jan 17, 2025

luacmartins left a comment

rayane-d commented Jan 20, 2025 •

edited

Loading

rayane-d left a comment

luacmartins commented Jan 21, 2025

rayane-d commented Jan 21, 2025 •

edited

Loading

Kicu commented Jan 22, 2025

Kicu commented Jan 22, 2025

luacmartins commented Jan 22, 2025

rayane-d left a comment

OSBotify commented Jan 23, 2025

github-actions bot commented Jan 23, 2025

github-actions bot commented Jan 28, 2025

		@@ -1247,8 +1247,6 @@ const styles = (theme: ThemeColors) =>
		},

		textInputAndIconContainer: {

Simplify single line TextInput styling to allow for different heights #55343

Simplify single line TextInput styling to allow for different heights #55343

Conversation

Kicu commented Jan 16, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 16, 2025

Kicu Jan 16, 2025

Choose a reason for hiding this comment

melvin-bot bot commented Jan 17, 2025

Kicu commented Jan 17, 2025

luacmartins left a comment

Choose a reason for hiding this comment

rayane-d commented Jan 20, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

rayane-d left a comment

Choose a reason for hiding this comment

luacmartins commented Jan 21, 2025

rayane-d commented Jan 21, 2025 • edited Loading

Kicu commented Jan 22, 2025

Kicu commented Jan 22, 2025

luacmartins commented Jan 22, 2025

rayane-d left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 23, 2025

github-actions bot commented Jan 23, 2025

github-actions bot commented Jan 28, 2025

Kicu commented Jan 16, 2025 •

edited

Loading

rayane-d commented Jan 20, 2025 •

edited

Loading

rayane-d commented Jan 21, 2025 •

edited

Loading