Add clickable custom emoji support for onboarding task #55222

Amoralchik · 2025-01-14T16:24:51Z

Explanation of Change

Add clickable custom emoji support for onboarding task

Fixed Issues

$ #54643
PROPOSAL: #54643 (comment)

Tests

Login with new account
Click the "Submit expense" task from Concierge
Make sure you can see a green emoji-like button inline with the text
Make sure you can click green button and finish Task (Create expense)

Offline tests

QA Steps

Create new account
Choose "Get paid back by my employer" option in onboarding
Click the "Submit expense" task from Concierge
Make sure you can see a green emoji-like button inline with the text
Make sure you can click green button and finish Task (Create expense)

PR Author Checklist

Screenshots/Videos

Android: Native

2025-01-31.18.09.35.mov

Android: mWeb Chrome

2025-01-31.18.15.52.mov

iOS: Native

2025-01-31.17.55.29.mov

iOS: mWeb Safari

2025-01-31.17.56.57.mov

MacOS: Chrome / Safari

2025-01-31.18.23.25.mov

MacOS: Desktop

2025-01-31.18.21.35.mov

melvin-bot · 2025-01-16T14:16:59Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dannymcclain · 2025-01-16T14:31:27Z

Hmm, I like the inclusion of the green plus button image... But I don't know how I feel about it being clickable and actually opening the GC menu. @Expensify/design how do you all feel about that? Was that decision made in a convo somewhere that I missed?

shawnborton · 2025-01-16T15:21:19Z

The relevant conversation is here.

I have mixed feelings. I don't love that this is kind of a "new" way to make an expense, but at the same time, I understand the need to educate our users. If it were up to me I would probably not do this one though, but others seemed to have felt strongly.

shawnborton · 2025-01-16T15:22:36Z

src/styles/index.ts

@@ -1658,6 +1658,15 @@ const styles = (theme: ThemeColors) =>
            justifyContent: 'center',
        },

+        floatingActionEmoji: {


cc @Expensify/design - part of me thinks we should just provide an .svg image for this rather than creating a custom element via styles.

@Amoralchik is there a reason why you didn't do this via an svg?

I not good at SVG, and because floatingActionButton already use two SVG elements, I decided to simply resize it

The design team will provide the svg. But I think it's implementation would be far simpler, and kind of paves the path for future custom emojis should we want more.

I think we might want to use a 20x20 frame, but inside of it use a 18x18 button so we get a little bit of space around the shape in case to prevent collisions with lines that may appear before/after. Basically the option on the right seems like it would be better to me:

@Amoralchik can you try with this image quickly? custom-emoji__global-create.svg.zip

Note that the svg is 20px tall, and the line height of the text surrounding it is also 20px tall. So it should all line up perfectly like this:

@shawnborton Hello, sorry for the wait. I’ve rewritten the code using the SVG icon you provided. I feel like I might not have fully understood what you meant, so here is the result with 18px and 20px sizes.

Before :

After:
With icon size 20px

With icon size 18px

Ah sorry, please use the icon I provided to you at 20px. What I did was make the inner green circle 18px within a 20px bounding box. Let me know if that makes sense.

@shawnborton Okay, I updated the code using an icon size of 20px. I was wondering if it might be worth increasing the size of the "+" icon. I know it might just be me, but I sometimes find it a bit hard to see it against a green circle.

I mean that this icon currently just replicates the main one, which is probably correct, but I think some people might find it hard to notice the "+" on a phone screen or a very large monitor.

Let's see what the other designers think, cc @Expensify/design

Personally I think it's fine because it's basically just a scaled down version of the existing global create, so it basically has the same proportions that the normal button has. I can see wanting to correct it optically a little bit, but it doesn't bother me personally.

I can see wanting to correct it optically a little bit, but it doesn't bother me personally.

This is pretty much exactly how I feel. I think it's probably fine as-is, so maybe we wait and see if we receive any feedback about it before changing it? Seems like a simple change to replace the SVG in the future if we think we need to.

dannymcclain · 2025-01-16T15:50:50Z

If it were up to me I would probably not do this one though, but others seemed to have felt strongly.

Ok thank you for the context! I guess I was involved in that convo and just didn't realize we were planning to add that functionality. I would prefer it to not have it, but I won't stand in the way.

quinthar · 2025-01-19T18:32:56Z

Just to confirm, this is kind of two totally different features at work:

We are adding a :global-create: emoji.
We are adding a expensify://global-create URL

These are completely distinct, unrelated features, that happen to work well together (ie, if you hyperlink :global-create: and use that URL, it'll open it). Just making sure we aren't doing something special to make that emoji have some kind of magic side effect everywhere it appers.

shawnborton · 2025-01-20T06:48:55Z

Just making sure we aren't doing something special to make that emoji have some kind of magic side effect everywhere it appears.

@quinthar is there something happening in this PR that caused you to make that comment? Just want to make sure I am understanding your concern correctly.

c3024 · 2025-01-20T13:45:22Z

@quinthar

The FAB does not have a screen. So, based on the Slack discussion, creating a link solely to open the FAB is odd. So, we are using custom renderers to open the popover as well when there is no screen associated with the popover.

When we want to simulate a button click to open a popover that does not have a screen (like the FAB in this case) for an emoji, we will use a default press attribute in the custom-emoji to make the emoji clickable.

We are adding a :global-create: emoji.
We are adding an expensify://global-create URL.
These are completely distinct, unrelated features that happen to work well together (i.e., if you hyperlink :global-create: and use that URL, it’ll open it).

For emojis linking to routes that exist, this is exactly how we do it:

[<custom-emoji emoji="emoji-name" />](URL)

However, when there is no URL or screen for the action triggered by clicking the emoji, we use:

<custom-emoji emoji="emoji-name" pressablewithdefault />

When the pressablewithdefault attribute is present, we attach a default onPress handler that opens the popover to the emoji. In the present case, we set the FAB visibility with this onPress handler.

Just making sure we aren't doing something special to make that emoji have some kind of magic side effect everywhere it appers.

So, this press effect does not appear everywhere the emoji is present but only at selective places where we pass the attribute.

…pense-task

Amoralchik · 2025-01-20T18:19:15Z

Updated
SVG icon
Refactoring code
Android app crashes after updating from main branch, for other re-record videos and update description

…pense-task

Amoralchik · 2025-01-21T15:18:09Z

Updated
Fix merge conflict

shawnborton · 2025-01-21T15:53:48Z

Going to run a test build on this one.

github-actions · 2025-01-21T15:54:07Z

🚧 @shawnborton has triggered a test build. You can view the workflow run here.

github-actions · 2025-01-21T16:19:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55222/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/55222/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/55222/NewExpensify.dmg	https://55222.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2025-01-21T16:53:29Z

The vertical alignment looks off:

Adding vertical-align: top seems to fix it at least?

Amoralchik · 2025-01-22T18:35:58Z

@c3024

I like the idea of using useContext and a Provider, but there will be a complete change to the logic of FloatingActionButtonAndPopover.PopoverMenu must be located elsewhere and accessible from any screen (for phones and small windows).

In short, FloatingActionButtonAndPopover must be rendered in the same place to be opened. In the current realization (in your and now in my branch), PopoverMenu is opened in the first screen where it is located. To fix that, FloatingActionButtonAndPopover will be just FloatingActionButton, which opens PopoverMenu that is moved to a place like provider.

I need your opinion before moving forward.

c3024 · 2025-01-23T02:09:27Z

@Amoralchik

PopoverMenu must be located elsewhere and accessible from any screen (for phones and small windows).

FAB stays mounted even on smaller screens as long as we are on the Central pane report screen. So, clicking on the + in the task description allows the popover to be shown over the report screen in smaller devices.

In short, FloatingActionButtonAndPopover must be rendered in the same place to be opened.

It opens at the same place as usual except that it is now not hidden for smaller screens and appears over the report pane in smaller screens.

Do you see any practical problems with opening the popover? Could you share a video of the issue you are seeing now?

Amoralchik · 2025-01-23T02:13:52Z

@c3024 can't show it now (going to sleep), please can you try it on iOS, or android, and also try make small window in browser then reload the page, and try custom emoji, in my cases, it not open, or opened on the main page (where you can see the fab)

c3024 · 2025-01-23T02:18:11Z

Screen.Recording.2025-01-23.at.7.45.02.AM.mov

This change already included in popover menu should have fixed that

-isVisible={isCreateMenuActive && (!shouldUseNarrowLayout || isFocused)}
+isVisible={isCreateMenuActive}

can't show it now (going to sleep)

Sure, please update when you are back online!

Amoralchik · 2025-01-23T14:48:47Z

@c3024 Here it is.
The problem has been fixed in the browser, but still got it on iOS.
I also got a warning about passing value to Provider in FABPopoverContext, so I wrapped it in useMemo.

2025-01-23.16.41.45-1-1.mov

Without this change FAB is still not openings:

2025-01-23.16.34.10-1-1-1.mov

c3024 · 2025-01-23T14:56:42Z

@Amoralchik

It worked for me on iOS. There should be no difference there too. Could you build the iOS app afresh and check?

Amoralchik · 2025-01-23T15:50:09Z

@c3024
Unfortunately, I still can't get it to work on IOS.

It looks like it works fine on other platforms,

So what do you think? maybe you can provide a video, and I can update the description with other videos, and we can move forward with it

…pense-task

c3024 · 2025-01-28T00:41:40Z

@Amoralchik

Sorry, I think I must have used your earlier PR when iOS worked. I checked and tried different ways to make this work on iOS but could not. On iOS, popovers do not seem to work for screens out of view in the same way as Android.

We gotta use your earlier solution of passing emoji prop to the FABPopover and FAB when we want the emoji to be interactive and open the FAB. Please remove the context based changes and let us use your earlier logic in CustomEmojiWithDefaultPressableAction so that popover works correctly on all platforms when clicked on task description. Thanks!

…uttonAndPopover

…pense-task

c3024 · 2025-01-29T12:02:53Z

src/CONST.ts

@@ -121,7 +121,7 @@ const onboardingEmployerOrSubmitMessage: OnboardingMessage = {
                '\n' +
                'Here’s how to submit an expense:\n' +
                '\n' +
-                '1. Click the green *+* button.\n' +
+                '1. Press the <custom-emoji emoji="action-menu-icon" pressablewithdefaultaction /> button.\n' +


If pressablewithdefaultaction is removed, it should render a non-interactive emoji. It is crashing for me for this case on web.

Screen.Recording.2025-01-29.at.5.29.49.PM.mov

Thanks for this, I think I know why it happened

Additionally sorry, I did not make full testing, I pushed to pull and check the IOS on the laptop

… rendering emoji content

Amoralchik · 2025-01-29T15:30:22Z

Updated

return earlier logic
Refactored, fixed

All video rerecorded

c3024 · 2025-01-31T06:03:43Z

src/libs/ReportUtils.ts

@@ -6412,6 +6412,7 @@ function buildOptimisticTaskReport(
    description?: string,
    policyID: string = CONST.POLICY.OWNER_EMAIL_FAKE,
    notificationPreference: NotificationPreference = CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,
+    shouldEscapeText?: boolean,


Suggested change

shouldEscapeText?: boolean,

shouldEscapeText = true,

parse of ExpensiMark uses true as default for shouldEscapeText. So, let us default this to true and override it only when required.

c3024 · 2025-01-31T06:07:29Z

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

+    const popoverMenu = (
+        <PopoverMenu
+            onClose={hideCreateMenu}
+            isVisible={isCreateMenuActive}


Suggested change

isVisible={isCreateMenuActive}

isVisible={isCreateMenuActive && (!shouldUseNarrowLayout || isFocused)}

Since we are using this component directly in task description too this change is not required. Let us keep it as it was.

c3024 · 2025-01-31T06:16:11Z

src/components/HTMLEngineProvider/HTMLRenderers/CustomEmojiRenderer.tsx

+import variables from '@styles/variables';
+
+// eslint-disable-next-line rulesdir/no-inline-named-export
+export const emojiMap: Record<string, FC<SvgProps>> = {


Let us minimize the lint overrides

Suggested change

export const emojiMap: Record<string, FC<SvgProps>> = {

const emojiMap: Record<string, FC<SvgProps>> = {

src/components/HTMLEngineProvider/HTMLRenderers/CustomEmojiRenderer.tsx

c3024 · 2025-01-31T06:16:40Z

src/components/HTMLEngineProvider/HTMLRenderers/CustomEmojiRenderer.tsx

+// eslint-disable-next-line rulesdir/no-inline-named-export
+export const emojiMap: Record<string, FC<SvgProps>> = {
+    // eslint-disable-next-line @typescript-eslint/naming-convention
+    'action-menu-icon': GlobalCreateIcon,


Suggested change

'action-menu-icon': GlobalCreateIcon,

'actionmenuicon': GlobalCreateIcon,

c3024 · 2025-01-31T06:20:54Z

src/components/HTMLEngineProvider/HTMLRenderers/CustomEmojiRenderer.tsx

+function CustomEmojiRenderer({tnode}: CustomRendererProps<TText | TPhrasing>) {
+    const styles = useThemeStyles();
+    const emojiKey = tnode.attributes.emoji;
+    const positionFix = Platform.OS !== 'web' && {height: '5%'};


I do not understand how restricting the height of the View moves its position on iOS. When I give a background color to the View with this styling the View appears very small and the image overflows but somehow it changes position. Can you please explain this? I have a suggestion using margin in styles/index as specified below which completely removes positionFix. Please check this and see if it is preferable.

src/styles/index.ts

…o review

Amoralchik · 2025-01-31T16:28:46Z

~~Updated~~

~~Changes based on the review~~

~~All video rerecorded~~

c3024 · 2025-01-31T16:55:00Z

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

+        />
+    );
+
+    const positionFix = Platform.OS !== 'web' && {height: '5%'};


I suggested removing positionFix here too here. This is also not required anymore. It looks fine after removing this in my testing on native apps. Have you found any issue with removing this?

No, sorry, I just forgot that we have positionFix here as well. I retested and everything good. Thank you for noticing this.

carlosmiceli · 2025-01-31T17:29:14Z

Let me know when this is ready for my review :)

…tyling

Amoralchik · 2025-01-31T17:49:37Z

Updated, and I think we're ready if @c3024 agrees

c3024 · 2025-01-31T18:22:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

fabAndroid.mov

Android: mWeb Chrome

fabAndroidmWeb.mov

iOS: Native

fabiOS.mov

iOS: mWeb Safari

fabiOSmWeb.mov

MacOS: Chrome / Safari

fabChrome.mov

fabChromeNarrow.mov

MacOS: Desktop

fabDesktop.mov

c3024

LGTM!

Amoralchik mentioned this pull request Jan 14, 2025

[$250] Improvement: Make the "press the green + button" text in the "Submit an Expense" task on mobile a clickable emoji #54643

Open

8 tasks

Amoralchik force-pushed the clickable-emoji-in-expense-task branch from dfc6476 to a61a8d5 Compare January 16, 2025 11:35

Amoralchik marked this pull request as ready for review January 16, 2025 14:16

Amoralchik requested review from a team as code owners January 16, 2025 14:16

melvin-bot bot requested review from c3024 and removed request for a team January 16, 2025 14:16

Add custom emoji functionality and for onboarding task

c446d64

Amoralchik force-pushed the clickable-emoji-in-expense-task branch from a61a8d5 to c446d64 Compare January 16, 2025 14:21

shawnborton reviewed Jan 16, 2025

View reviewed changes

Add GlobalCreate svg and update FloatingActionButton to use it

238cfa8

Amoralchik added 2 commits January 20, 2025 16:16

Merge remote-tracking branch 'origin/main' into clickable-emoji-in-ex…

897fcde

…pense-task

Fix FloatingActionButton emoji styles for ios and android

b1e3dbc

Amoralchik force-pushed the clickable-emoji-in-expense-task branch from f508b3b to b1e3dbc Compare January 20, 2025 18:00

Merge remote-tracking branch 'origin/main' into clickable-emoji-in-ex…

1fb883d

…pense-task

shawnborton added the Ready To Build label Jan 21, 2025

Fix FloatingActionButton emoji position

885da3e

Refactor custom emoji handling via FABProvider

4a1e6fe

Amoralchik added 2 commits January 24, 2025 22:03

Fix emoji position for non-web platforms in CustomEmoji components

4686987

Merge remote-tracking branch 'origin/main' into clickable-emoji-in-ex…

ee33234

…pense-task

Amoralchik force-pushed the clickable-emoji-in-expense-task branch from c8913e5 to ee33234 Compare January 24, 2025 20:04

Amoralchik added 2 commits January 29, 2025 02:15

refactor CustomEmojiWithDefaultPressableAction to use FloatingActionB…

b313b5e

…uttonAndPopover

Merge remote-tracking branch 'origin/main' into clickable-emoji-in-ex…

8d43075

…pense-task

c3024 suggested changes Jan 29, 2025

View reviewed changes

refactor CustomEmojiWithDefaultPressableAction to accept children for…

6defcc7

… rendering emoji content

c3024 suggested changes Jan 31, 2025

View reviewed changes

refactor emoji keys in onboarding messages and components according t…

60d06bf

…o review

c3024 approved these changes Jan 31, 2025

View reviewed changes

melvin-bot bot requested a review from carlosmiceli January 31, 2025 16:55

refactor FloatingActionButtonAndPopover to remove platform-specific s…

f14215e

…tyling

c3024 approved these changes Jan 31, 2025

View reviewed changes

carlosmiceli approved these changes Jan 31, 2025

View reviewed changes

carlosmiceli merged commit e69cf96 into Expensify:main Jan 31, 2025
17 checks passed

github-actions bot mentioned this pull request Jan 31, 2025

Investigate workflow job failing on main: test / test (job 2) #56190

Closed

	isVisible={isCreateMenuActive}
	isVisible={isCreateMenuActive && (!shouldUseNarrowLayout \|\| isFocused)}

	export const emojiMap: Record<string, FC<SvgProps>> = {
	const emojiMap: Record<string, FC<SvgProps>> = {

	'action-menu-icon': GlobalCreateIcon,
	'actionmenuicon': GlobalCreateIcon,

Add clickable custom emoji support for onboarding task #55222

Add clickable custom emoji support for onboarding task #55222

Conversation

Amoralchik commented Jan 14, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 16, 2025

dannymcclain commented Jan 16, 2025

shawnborton commented Jan 16, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Amoralchik Jan 17, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dannymcclain commented Jan 16, 2025

quinthar commented Jan 19, 2025

shawnborton commented Jan 20, 2025

c3024 commented Jan 20, 2025

Amoralchik commented Jan 20, 2025

Amoralchik commented Jan 21, 2025

shawnborton commented Jan 21, 2025

github-actions bot commented Jan 21, 2025

github-actions bot commented Jan 21, 2025

shawnborton commented Jan 21, 2025

Amoralchik commented Jan 22, 2025 • edited Loading

c3024 commented Jan 23, 2025

Amoralchik commented Jan 23, 2025

c3024 commented Jan 23, 2025

Amoralchik commented Jan 23, 2025 • edited Loading

c3024 commented Jan 23, 2025

Amoralchik commented Jan 23, 2025

c3024 commented Jan 28, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Amoralchik commented Jan 29, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Amoralchik commented Jan 31, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlosmiceli commented Jan 31, 2025

Amoralchik commented Jan 31, 2025

c3024 commented Jan 31, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

c3024 left a comment

Choose a reason for hiding this comment

Amoralchik commented Jan 14, 2025 •

edited

Loading

Amoralchik Jan 17, 2025 •

edited

Loading

Amoralchik commented Jan 22, 2025 •

edited

Loading

Amoralchik commented Jan 23, 2025 •

edited

Loading

Amoralchik commented Jan 31, 2025 •

edited

Loading

c3024 commented Jan 31, 2025 •

edited

Loading