[No QA] Hybrid App adhoc builds follow ups #55061

jnowakow · 2025-01-10T09:28:54Z

Explanation of Change

This change allows author of PR specify PR number in Mobile-Expensify repo against which they want to trigger hybrid app Adhoc build. It's done by specifying it in PR description like below:

MOBILE-EXPENSIFY: 1232

Fixed Issues

$ #51636
PROPOSAL: N/A

Tests

As a mobile deployer, kick off two builds:
- One without MOBILE-EXPENSIFY: my-branch
- One with MOBILE-EXPENSIFY: my-branch pointing to a specific branch that is distinct from main
The builds should both succeed
The builds should differ based on the changes in the branch

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

N/A

MacOS: Desktop

N/A

melvin-bot · 2025-01-10T09:28:59Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss

Hey @jnowakow. Just to make sure I understand, these changes remove the additional field from the action and then lets PR authors add it to the PR description instead?

It seems a bit of a hidden feature, but I wanted to check if this was discussed somewhere. Maybe there was a reason for this.

jnowakow · 2025-01-14T10:33:26Z

Hey @Julesssss, yes you're right. We discussed it internally and decided that we can give it a try. We think it's better because it doesn't require internal developers to remember if someone asked them to run workflow with OD's commit. They just run the workflow and it's on PR's author specify branch/commit they want to build from

Julesssss · 2025-01-15T16:31:47Z

Thanks @jnowakow.

I'll just give app deployers a chance to review, as these are the people using the ahoc build tool

Julesssss · 2025-01-15T16:35:36Z

Hi @Expensify/mobile-deployers, this PR changes how AdHoc HybridApp builds work. Please take a look and share any concerns before we move forward!

Essentially, we would pick up this paramMOBILE-EXPENSIFY: my-branch from within the App PR to simplify kicking off the Action. No need to manually paste the desired Mobile-Expensify branch or commit.

.github/PULL_REQUEST_TEMPLATE.md

.github/workflows/testBuildHybrid.yml

mountiny · 2025-01-17T15:30:23Z

Looks good to me, should we test it out? @Julesssss @AndrewGable

Julesssss · 2025-01-17T17:58:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Julesssss

LGTM. But we 100% need to test and possibly improve after merging.

For that reason I'd like to wait until next Tuesday (Monday is US holiday). I',m happy to perform all the testing and necessary deployment here.

Julesssss

Okay, lets test this out 👍

OSBotify · 2025-01-21T22:34:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Julesssss · 2025-01-21T22:34:45Z

Requesting a CP to speed up verification of these changes here

…ybrid-follow-ups [No QA] Hybrid App adhoc builds follow ups (cherry picked from commit 51efa26) (CP triggered by Julesssss)

github-actions · 2025-01-21T23:14:56Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.88-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-22T01:38:20Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.88-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

mountiny · 2025-01-22T14:22:44Z

.github/workflows/testBuildHybrid.yml

+            const pullRequest = await github.rest.pulls.get({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              pull_number: env.PULL_REQUEST_NUMBER,


We need to use process.env here otherwise the env is not defined. Fixing it here #55577

github-actions · 2025-01-23T18:06:05Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.88-7 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

jnowakow added 2 commits January 8, 2025 16:41

Adhoc builds workflow follow up

a15d731

Let author of PR specify Mobile-Expensify placement

b088527

jnowakow requested a review from a team as a code owner January 10, 2025 09:28

melvin-bot bot requested review from allroundexperts and removed request for a team January 10, 2025 09:28

jnowakow added 5 commits January 10, 2025 10:35

Don't repeat request

4201baf

fix workflow

ac7b3ef

fix workflow 2

37fb883

fix workflow 3

11a5667

Correct app id when launching android from terminal

ea80bcf

Julesssss reviewed Jan 14, 2025

View reviewed changes

mountiny reviewed Jan 15, 2025

View reviewed changes

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved

AndrewGable reviewed Jan 15, 2025

View reviewed changes

.github/workflows/testBuildHybrid.yml Show resolved Hide resolved

mountiny assigned jnowakow Jan 17, 2025

jnowakow added 2 commits January 17, 2025 15:33

Merge branch 'main' into jnowakow/adhoc-hybrid-follow-ups

ee64e14

Checkout to PR ref instead of branch that exist only in fork

b1f9db6

Julesssss removed the request for review from allroundexperts January 17, 2025 17:58

Julesssss approved these changes Jan 17, 2025

View reviewed changes

Julesssss approved these changes Jan 21, 2025

View reviewed changes

Julesssss merged commit 51efa26 into Expensify:main Jan 21, 2025
12 of 13 checks passed

OSBotify pushed a commit that referenced this pull request Jan 21, 2025

Merge pull request #55061 from software-mansion-labs/jnowakow/adhoc-h…

e2ec981

…ybrid-follow-ups [No QA] Hybrid App adhoc builds follow ups (cherry picked from commit 51efa26) (CP triggered by Julesssss)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Jan 21, 2025

github-actions bot mentioned this pull request Jan 21, 2025

Deploy Checklist: New Expensify 2025-01-21 #55507

Closed

53 tasks

mateuuszzzzz mentioned this pull request Jan 22, 2025

Android HybridApp shows error after successful build #54880

Closed

mountiny reviewed Jan 22, 2025

View reviewed changes

melvin-bot bot mentioned this pull request Jan 23, 2025

Enable HybridApp test builds in App repo #51636

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Hybrid App adhoc builds follow ups #55061

[No QA] Hybrid App adhoc builds follow ups #55061

jnowakow commented Jan 10, 2025 •

edited

Loading

melvin-bot bot commented Jan 10, 2025

Julesssss left a comment

jnowakow commented Jan 14, 2025

Julesssss commented Jan 15, 2025

Julesssss commented Jan 15, 2025

mountiny commented Jan 17, 2025

Julesssss commented Jan 17, 2025 •

edited

Loading

Julesssss left a comment

Julesssss left a comment

OSBotify commented Jan 21, 2025

Julesssss commented Jan 21, 2025

github-actions bot commented Jan 21, 2025

github-actions bot commented Jan 22, 2025

mountiny Jan 22, 2025

github-actions bot commented Jan 23, 2025

[No QA] Hybrid App adhoc builds follow ups #55061

[No QA] Hybrid App adhoc builds follow ups #55061

Conversation

jnowakow commented Jan 10, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 10, 2025

Julesssss left a comment

Choose a reason for hiding this comment

jnowakow commented Jan 14, 2025

Julesssss commented Jan 15, 2025

Julesssss commented Jan 15, 2025

mountiny commented Jan 17, 2025

Julesssss commented Jan 17, 2025 • edited Loading

Reviewer Checklist

Julesssss left a comment

Choose a reason for hiding this comment

Julesssss left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 21, 2025

Julesssss commented Jan 21, 2025

github-actions bot commented Jan 21, 2025

github-actions bot commented Jan 22, 2025

mountiny Jan 22, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 23, 2025

jnowakow commented Jan 10, 2025 •

edited

Loading

Julesssss commented Jan 17, 2025 •

edited

Loading