Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO QA] feat: Step 4 logic #54280

Merged
merged 42 commits into from
Feb 7, 2025

Conversation

MrMuzyk
Copy link
Contributor

@MrMuzyk MrMuzyk commented Dec 18, 2024

Explanation of Change

  • Implements validation, API, navigation and other logic for step 4 in global reimbursements flow
  • Minor improvements for previous steps

Fixed Issues

$ #50906
PROPOSAL:

Tests

  • Change workspace currency to EUR, GBP, CAD or AUD
  • Enable workflows for the workspace
  • Open workflows
  • Try to connect a bank account
  • Go to the fourth step
  • Fill out all the forms and send data
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

N/A

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android.native.mp4
Android: mWeb Chrome
android.web.mp4
iOS: Native
ios.native.mp4
iOS: mWeb Safari
ios.web.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4

@MrMuzyk MrMuzyk changed the title feat: Step 4 logic [NO QA] feat: Step 4 logic Dec 20, 2024
@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Jan 31, 2025

Hey @hungvu193 ! So BE is working at the moment but it only supports a single file upload. We've agreed with @madmax330 to update it in the following issue and for now go with what we have. I've added a TODO note in the line that will be changed before we go live with this feature. I hope this is ok and we can test it now and close it.

@hungvu193
Copy link
Contributor

Hey @hungvu193 ! So BE is working at the moment but it only supports a single file upload. We've agreed with @madmax330 to update it in the following issue and for now go with what we have. I've added a TODO note in the line that will be changed before we go live with this feature. I hope this is ok and we can test it now and close it.

Cool cool. I'll retest today and let you know.

@hungvu193
Copy link
Contributor

All good. I'll complte the checklist today!

@hungvu193
Copy link
Contributor

hungvu193 commented Feb 1, 2025

@MrMuzyk If I didn't add any owner then I got this issue:

"400 Invalid field in inputs"
Screen.Recording.2025-02-01.at.22.53.45.mov

I think there's validation mismatch between BE and FE right?

Here's the curl curl 'https://dev.new.expensify.com:8082/api/SaveCorpayOnboardingBeneficialOwner?' \ -H 'Accept: */*' \ -H 'Accept-Language: en-US,en;q=0.9' \ -H 'Connection: keep-alive' \ -H 'Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryyGZ2iI3qo8nRlFTP' \ -H 'Origin: https://dev.new.expensify.com:8082' \ -H 'Referer: https://dev.new.expensify.com:8082/bank-account/new?backTo=settings%2Fworkspaces%2F7712D7510816D306%2Fworkflows&policyID=7712D7510816D306' \ -H 'Sec-Fetch-Dest: empty' \ -H 'Sec-Fetch-Mode: cors' \ -H 'Sec-Fetch-Site: same-origin' \ -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36' \ -H 'sec-ch-ua: "Not A(Brand";v="8", "Chromium";v="132", "Google Chrome";v="132"' \ -H 'sec-ch-ua-mobile: ?0' \ -H 'sec-ch-ua-platform: "macOS"' \ --data-raw $'------WebKitFormBoundaryyGZ2iI3qo8nRlFTP\r\nContent-Disposition: form-data; name="inputs"\r\n\r\n{"anyIndividualOwn25PercentOrMore":false}\r\n------WebKitFormBoundaryyGZ2iI3qo8nRlFTP\r\nContent-Disposition: form-data; name="beneficialOwnerIDs"\r\n\r\n\r\n------WebKitFormBoundaryyGZ2iI3qo8nRlFTP\r\nContent-Disposition: form-data; name="bankAccountID"\r\n\r\n6913529\r\n------WebKitFormBoundaryyGZ2iI3qo8nRlFTP\r\nContent-Disposition: form-data; name="apiRequestType"\r\n\r\nwrite\r\n------WebKitFormBoundaryyGZ2iI3qo8nRlFTP\r\nContent-Disposition: form-data; name="pusherSocketID"\r\n\r\n823322.629469\r\n------WebKitFormBoundaryyGZ2iI3qo8nRlFTP\r\nContent-Disposition: form-data; name="shouldRetry"\r\n\r\ntrue\r\n------WebKitFormBoundaryyGZ2iI3qo8nRlFTP\r\nContent-Disposition: form-data; name="canCancel"\r\n\r\ntrue\r\n------WebKitFormBoundaryyGZ2iI3qo8nRlFTP\r\nContent-Disposition: form-data; name="authToken"\r\n\r\nEDBDCCA2E6E95BB8810C0F547C5B608B3F0BE6BD0367FD87CA45A785980877222C02574AA802D4868E1F884BC44DD2EDC04DBECE7D1D7F631C8B1B21C8582BC42D09CCC6514E55AEA8E6D4305975A0A85A9962BA10C0BF09876ED110EC11CCEFBEEF1AD7381F275F2B4C791675F157D9735FA4FEB11800EEA0A648505EFDA69088819AF48E58E7DCED61BBFF3B3EDA7050AA52CD71558A4AE94D574FC82750E1D2B81BEBB83E14FBBE1E25493B8E3F01AD1B613331F83862E1512BB00D22E9D87758FDD6D93F2198C550FBA088C30754221D041D8F5FD485299C15350B7E5921A8CD4FE6368319CA0962AF76A6570199018AAE8E1C002ACC7D1554A27E8C401B261EDE295C2D24E7EFF678043E701BE3DE006F389EC0F7070C983C7B42C186A4552CCCDFDCE4B0F6F2B6E5CC148890CAED95587ABC29C2E22F0F314B076CCF05182BBAE043707EAC4517C71044A6CF59FA7424FDFFF8AEDC6402067E33C986F2\r\n------WebKitFormBoundaryyGZ2iI3qo8nRlFTP\r\nContent-Disposition: form-data; name="referer"\r\n\r\necash\r\n------WebKitFormBoundaryyGZ2iI3qo8nRlFTP\r\nContent-Disposition: form-data; name="platform"\r\n\r\nweb\r\n------WebKitFormBoundaryyGZ2iI3qo8nRlFTP\r\nContent-Disposition: form-data; name="api_setCookie"\r\n\r\nfalse\r\n------WebKitFormBoundaryyGZ2iI3qo8nRlFTP\r\nContent-Disposition: form-data; name="email"\r\n\r\[email protected]\r\n------WebKitFormBoundaryyGZ2iI3qo8nRlFTP\r\nContent-Disposition: form-data; name="isFromDevEnv"\r\n\r\ntrue\r\n------WebKitFormBoundaryyGZ2iI3qo8nRlFTP\r\nContent-Disposition: form-data; name="appversion"\r\n\r\n9.0.93-1\r\n------WebKitFormBoundaryyGZ2iI3qo8nRlFTP\r\nContent-Disposition: form-data; name="clientUpdateID"\r\n\r\n4040323493\r\n------WebKitFormBoundaryyGZ2iI3qo8nRlFTP--\r\n'

@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Feb 3, 2025

Looking into it

@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Feb 4, 2025

@hungvu193 Max fixed it on his end and PR will probably be deployed to staging today. On my end, Ive made param with owner keys optional and added a loader to be displayed on the button when request is being processed

@hungvu193
Copy link
Contributor

@hungvu193 Max fixed it on his end and PR will probably be deployed to staging today. On my end, Ive made param with owner keys optional and added a loader to be displayed on the button when request is being processed

Awesome. I'll retest once BE is ready

@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Feb 6, 2025

Hey @hungvu193, BE was deployed and case where there are no owners works right now :)

@hungvu193
Copy link
Contributor

Oops, I think I think I still have the error if I added the owners and submit: (it worked fine if I didn't add any owner)

Screen.Recording.2025-02-06.at.16.21.43.mov

@hungvu193
Copy link
Contributor

Here's the cURL.

cURL curl 'https://dev.new.expensify.com:8082/staging/api/SaveCorpayOnboardingBeneficialOwner?' \ -H 'Accept: */*' \ -H 'Accept-Language: en-US,en;q=0.9' \ -H 'Connection: keep-alive' \ -H 'Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryBuBVeBxBT9dEf2de' \ -H 'Origin: https://dev.new.expensify.com:8082' \ -H 'Referer: https://dev.new.expensify.com:8082/bank-account/new?backTo=settings%2Fworkspaces%2FBC56935A25654C33%2Fworkflows&policyID=BC56935A25654C33' \ -H 'Sec-Fetch-Dest: empty' \ -H 'Sec-Fetch-Mode: cors' \ -H 'Sec-Fetch-Site: same-origin' \ -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36' \ -H 'sec-ch-ua: "Google Chrome";v="131", "Chromium";v="131", "Not_A Brand";v="24"' \ -H 'sec-ch-ua-mobile: ?0' \ -H 'sec-ch-ua-platform: "macOS"' \ --data-raw $'------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="inputs"\r\n\r\n{"beneficialOwner_bd542822-756e-f570-8ee9-8f97d1f9812a_fullName":"han vu","beneficialOwner_bd542822-756e-f570-8ee9-8f97d1f9812a_ownershipPercentage":"33%","beneficialOwner_bd542822-756e-f570-8ee9-8f97d1f9812a_dob":"2007-02-01","beneficialOwner_bd542822-756e-f570-8ee9-8f97d1f9812a_ssnLast4":"4444","beneficialOwner_bd542822-756e-f570-8ee9-8f97d1f9812a_residentialAddress":"125 Rooney Circle, Aspen, CO, 81611","beneficialOwner_bd542822-756e-f570-8ee9-8f97d1f9812a_nationality":"US","anyIndividualOwn25PercentOrMore":true}\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="beneficialOwner_bd542822-756e-f570-8ee9-8f97d1f9812a_proofOfBeneficialOwner"; filename="splash.png"\r\nContent-Type: image/png\r\n\r\n\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="beneficialOwner_bd542822-756e-f570-8ee9-8f97d1f9812a_copyOfIDForBeneficialOwner"; filename="splash.png"\r\nContent-Type: image/png\r\n\r\n\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="beneficialOwner_bd542822-756e-f570-8ee9-8f97d1f9812a_addressProofForBeneficialOwner"; filename="splash.png"\r\nContent-Type: image/png\r\n\r\n\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="beneficialOwnerIDs"\r\n\r\nbd542822-756e-f570-8ee9-8f97d1f9812a\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="bankAccountID"\r\n\r\n6944854\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="apiRequestType"\r\n\r\nwrite\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="pusherSocketID"\r\n\r\n824295.868070\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="shouldRetry"\r\n\r\ntrue\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="canCancel"\r\n\r\ntrue\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="authToken"\r\n\r\n3B3402BB4EDFFAC7F2E3D844E7F29957CBBDED43E3D5F5303DE5E5A9F0A60E1AFF5B005B1C7F54C0B6FF81C6298CF7432D967F0474181042EBAFC50A9F07BA6BB414D74036F73E076938C991ACF9A2EEB6AED17EC2F912E82F0DDC9559D08626B924A07A2625871DBC5E72208A18E2B97C214C2D03AC7CCE1D99EA9022663CD9851E6213C18CAC446610B2D49A04716D4B1E12107D1F6219D48C37707B89F32FE59CF58D9EBE276CAB88123E0B0CFD1F339D116A277C46B33A29AB8694DCDBA918394817C97B094EFD19139E48D55580F25F17DF27ECE84E5D29E0CDC9A4C31832542A9231D6E5F35D91DA01B06315851064F1B0606CE0CF1B07EC84AB492CAFABC869C02A6903CD63138618223C5A0703AEB41172205452C160F8991FAEF98A16DFC60C77DCC5682C5F6F4EC24D8EEFD9B4F6655535ECA8328A8708783D384A78E7E2DB210C994A5AD526B6E4E766D150200AF4F13265FF0DC30A4B22938462\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="referer"\r\n\r\necash\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="platform"\r\n\r\nweb\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="api_setCookie"\r\n\r\nfalse\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="email"\r\n\r\[email protected]\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="isFromDevEnv"\r\n\r\ntrue\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="appversion"\r\n\r\n9.0.94-1\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de\r\nContent-Disposition: form-data; name="clientUpdateID"\r\n\r\n4105445337\r\n------WebKitFormBoundaryBuBVeBxBT9dEf2de--\r\n'

@madmax330
Copy link
Contributor

@hungvu193 is there any reason you're testing with curl instead of through the app?
It looks like your payload is missing the beneficialOwnerIDs input.

@hungvu193
Copy link
Contributor

@hungvu193 is there any reason you're testing with curl instead of through the app? It looks like your payload is missing the beneficialOwnerIDs input.

I'm testing through the app, but I copied the cURL here for better investigation in case my input has anything incorrect.

@hungvu193
Copy link
Contributor

Ok, I see the issue here. So the issue I posted above will happen if I submitted successfully at step 4.
After that I go back to the steps 4 and change the owner informations and submit again.
cc @MrMuzyk

@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Feb 6, 2025

Can you please retry in completely fresh workspace? Because I just tested following scenario in single workspace:

  • no owners -> saved
  • one owner -> saved
  • one owner, different data -> saved
  • two owners -> saved
  • two owners, different data -> saved

All worked fine, back to back in same workspace

@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Feb 6, 2025

I think yesterday there was also a BE change regarding data being saved inside achData in reimbursement account. In order for that to work correctly a creation of fresh workspace was needed so it might be the case the something is broken in yours 😓

@hungvu193
Copy link
Contributor

Let me try 🤞

@hungvu193
Copy link
Contributor

@MrMuzyk Yeah I think you were right. I couldn't reproduce it with brand new workspace

@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Feb 6, 2025

Cool, let me know if there is anything else that needs fixing, otherwise Im hoping to merge that tomorrow if its possible :)

@hungvu193
Copy link
Contributor

All good. I'm finishing the checklist by now

@hungvu193
Copy link
Contributor

hungvu193 commented Feb 6, 2025

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Screen.Recording.2025-02-07.at.00.43.48.mov
Android: mWeb Chrome
Screen.Recording.2025-02-07.at.00.09.00.mov
iOS: Native
Screen.Recording.2025-02-06.at.23.46.04.mov
iOS: mWeb Safari
Screen.Recording.2025-02-06.at.23.53.28.mov
MacOS: Chrome / Safari
Chrome.mov
MacOS: Desktop
Screen.Recording.2025-02-06.at.17.53.13.mov

@melvin-bot melvin-bot bot requested a review from madmax330 February 6, 2025 17:14
@madmax330 madmax330 merged commit 6842b46 into Expensify:main Feb 7, 2025
17 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented Feb 7, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants